From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760255AbXEKJ6t (ORCPT ); Fri, 11 May 2007 05:58:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759065AbXEKJ6e (ORCPT ); Fri, 11 May 2007 05:58:34 -0400 Received: from smtp1.linux-foundation.org ([65.172.181.25]:48067 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756348AbXEKJ6c (ORCPT ); Fri, 11 May 2007 05:58:32 -0400 Date: Fri, 11 May 2007 02:58:22 -0700 From: Andrew Morton To: David Howells Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] AFS: Fix interminable loop in afs_write_back_from_locked_page() Message-Id: <20070511025822.a5aa5240.akpm@linux-foundation.org> In-Reply-To: <8792.1178876963@redhat.com> References: <20070510161946.96ff0784.akpm@linux-foundation.org> <20070510143334.19485.26042.stgit@warthog.cambridge.redhat.com> <8792.1178876963@redhat.com> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 May 2007 10:49:23 +0100 David Howells wrote: > Andrew Morton wrote: > > > > Following bug was uncovered by compiling with '-W' flag: > > > > gcc -W finds a number of fairly scary bugs. > > Do you mean in my code specifically? Or in the kernel in general? In general. > As far as > I can tell -W only finds an eye-glazingly large quantity of 'unused parameter' > warnings in AFS and AF_RXRPC. Yes, it's a shame that there doesn't seem to be a fine-grained way of turning on -W's useful bits.