mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Russell King <rmk@arm.linux.org.uk>, Jordi Colomer <jco@ict.es>
Subject: Re: [PATCH] Fix UCB1x00 driver to use sched_setscheduler
Date: Fri, 11 May 2007 13:32:45 +0200	[thread overview]
Message-ID: <20070511113245.GA27358@elf.ucw.cz> (raw)
In-Reply-To: <87ps57ejah.wl%takeuchi_satoru@jp.fujitsu.com>

Hi!

> Fix Touchscreen driver for UCB1x00-based touchscreens to use
> sched_setscheduler() instead of setting the fields of task_struct directly.
> 
> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>

Looks ok to me.
								Pavel

> Index: linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c
> ===================================================================
> --- linux-2.6.21-fix-ucb-drivers.orig/drivers/mfd/ucb1x00-ts.c	2007-05-11 18:53:36.000000000 +0900
> +++ linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c	2007-05-11 19:33:20.000000000 +0900
> @@ -214,8 +214,9 @@ static int ucb1x00_thread(void *_ts)
>  	 * We could run as a real-time thread.  However, thus far
>  	 * this doesn't seem to be necessary.
>  	 */
> -//	tsk->policy = SCHED_FIFO;
> -//	tsk->rt_priority = 1;
> +//	struct sched_param param = { .sched_priority = 1 };
> +//
> +//	sched_setscheduler(tsk, SCHED_FIFO, &param);
>  
>  	valid = 0;
>  

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2007-05-11 11:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-11 10:39 Satoru Takeuchi
2007-05-11 11:32 ` Pavel Machek [this message]
2007-05-12 13:10 ` Thomas Gleixner
2007-05-13 23:56   ` Satoru Takeuchi
2007-05-14  9:21     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070511113245.GA27358@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=jco@ict.es \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=takeuchi_satoru@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®