From: David Howells <dhowells@redhat.com>
To: akpm@osdl.org, nickpiggin@yahoo.com.au
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
dhowells@redhat.com
Subject: [PATCH 1/2] AFS: Fix afs_prepare_write()
Date: Tue, 15 May 2007 16:52:24 +0100 [thread overview]
Message-ID: <20070515155224.29345.22719.stgit@warthog.cambridge.redhat.com> (raw)
afs_prepare_write() should not mark a page up to date if it only partially
fills it in, in expectation of the caller filling in the rest prior to calling
commit_write(). commit_write(), however, should mark the page up to date.
Signed-off-by: David Howells <dhowells@redhat.com>
---
fs/afs/write.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/afs/write.c b/fs/afs/write.c
index 28f3751..a03b92a 100644
--- a/fs/afs/write.c
+++ b/fs/afs/write.c
@@ -206,7 +206,6 @@ int afs_prepare_write(struct file *file, struct page *page,
_leave(" = %d [prep]", ret);
return ret;
}
- SetPageUptodate(page);
}
try_again:
@@ -311,8 +310,8 @@ int afs_commit_write(struct file *file, struct page *page,
spin_unlock(&vnode->writeback_lock);
}
+ SetPageUptodate(page);
set_page_dirty(page);
-
if (PageDirty(page))
_debug("dirtied");
next reply other threads:[~2007-05-15 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 15:52 David Howells [this message]
2007-05-15 15:52 ` [PATCH 2/2] AFS: Implement shared-writable mmap David Howells
2007-05-15 21:40 ` Andrew Morton
2007-05-16 0:41 ` Nick Piggin
2007-05-16 16:36 ` Hugh Dickins
2007-05-16 17:14 ` Nick Piggin
2007-05-16 17:26 ` Hugh Dickins
2007-05-16 17:30 ` Nick Piggin
2007-05-16 17:34 ` Chuck Ebbert
2007-05-16 17:48 ` David Howells
2007-05-16 0:32 ` Nick Piggin
2007-05-16 7:10 ` Christoph Hellwig
2007-05-16 7:17 ` Nick Piggin
2007-05-16 0:24 ` [PATCH 1/2] AFS: Fix afs_prepare_write() Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070515155224.29345.22719.stgit@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®