From: Heikki Orsila <shdl@zakalwe.fi>
To: Richard Purdie <richard@openedhand.com>
Cc: akpm <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Nitin Gupta <nitingupta910@gmail.com>
Subject: Re: [PATCH -mm] LZO: Further cleanup of the kernel LZO library headers
Date: Fri, 18 May 2007 19:05:07 +0300 [thread overview]
Message-ID: <20070518160507.GI10873@zakalwe.fi> (raw)
In-Reply-To: <1179499886.5876.30.camel@localhost.localdomain>
On Fri, May 18, 2007 at 03:51:26PM +0100, Richard Purdie wrote:
> A further cleanup of the kernel LZO library headers which untangles and
> removes ~400 lines of defines. This doesn't change the core minilzo code
> so diffability is maintained.
You should just throw away that. Guptas implementation is much cleaner,
work with that. Putting a few bound checks into Guptas version will
solve crashes and overruns by returning an error.
--
Heikki Orsila Barbie's law:
heikki.orsila@iki.fi "Math is hard, let's go shopping!"
http://www.iki.fi/shd
prev parent reply other threads:[~2007-05-18 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-18 14:51 Richard Purdie
2007-05-18 16:05 ` Heikki Orsila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070518160507.GI10873@zakalwe.fi \
--to=shdl@zakalwe.fi \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nitingupta910@gmail.com \
--cc=richard@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®