mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Factor out common MODULE_INFO content from module*.h files.
Date: Mon, 21 May 2007 06:52:49 +0200	[thread overview]
Message-ID: <20070521045249.GA30018@uranus.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0705201651570.19270@localhost.localdomain>

> 
> under the circumstances, is there *any* cleanup worth doing WRT to
> this issue?  because of the fact that module.h currently includes
> moduleparam.h, developers have been able to get away with being
> incredibly sloppy in their includes.

It is wortwhile to make module.h independent of moduleparam.h.
The MODULE_INFO stuff has nothing to do with module parameters.

But keep the include so you do not break the > 500 drivers.

	Sam

  reply	other threads:[~2007-05-21  4:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-20 19:06 Robert P. J. Day
2007-05-20 19:15 ` Sam Ravnborg
2007-05-20 19:51   ` Robert P. J. Day
2007-05-20 20:13     ` Sam Ravnborg
2007-05-20 20:06   ` Robert P. J. Day
2007-05-20 20:51     ` Sam Ravnborg
2007-05-20 21:12       ` Robert P. J. Day
2007-05-21  4:52         ` Sam Ravnborg [this message]
2007-05-21  8:37           ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070521045249.GA30018@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®