From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <ak@suse.de>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -ak] Fix missing include
Date: Tue, 22 May 2007 09:39:35 +0200 [thread overview]
Message-ID: <20070522073935.GA8896@uranus.ravnborg.org> (raw)
In-Reply-To: <1179818895.12708.98.camel@chaos>
On Tue, May 22, 2007 at 09:28:15AM +0200, Thomas Gleixner wrote:
> On Tue, 2007-05-22 at 08:20 +0200, Andi Kleen wrote:
> > On Monday 21 May 2007 22:03, Thomas Gleixner wrote:
> > > ftp://firstfloor.org/pub/ak/x86_64/quilt/x86_64-2.6.22-rc2-070521-1.bz2
> > >
> > > explodes in various places due to missing defines of __cold. We can't
> > > rely on the assumption that linux/compiler.h is included magically
> > > before bug.h is included. Include it explicitely.
> >
> > Hmm, somehow it worked here. Perhaps longer term it would be a good
> > idea to turn compiler.h into an -include
>
> Might be not a bad idea. > 300 files include it directly and it's
> included from sched.h & co as well.
How about a file like:
include/linux/always_include.h
This file could then include autoconf.h + compiler.h
So we avoid an even longer gcc commandline.
Sam
prev parent reply other threads:[~2007-05-22 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 20:03 Thomas Gleixner
2007-05-22 6:20 ` Andi Kleen
2007-05-22 7:28 ` Thomas Gleixner
2007-05-22 7:39 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070522073935.GA8896@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®