mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Wayne Sherman <wsherman@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: PCI device problem - MMCONFIG, cannot allocate resource region, resource collisions
Date: Wed, 23 May 2007 13:26:34 +0400	[thread overview]
Message-ID: <20070523132634.A16545@jurassic.park.msu.ru> (raw)
In-Reply-To: <200705221631.22456.jbarnes@virtuousgeek.org>; from jbarnes@virtuousgeek.org on Tue, May 22, 2007 at 04:31:22PM -0700

On Tue, May 22, 2007 at 04:31:22PM -0700, Jesse Barnes wrote:
> On Tuesday, May 22, 2007, Wayne Sherman wrote:
> > If so, the D-Link is not being mapped into the 
> > right region, and the bridge it is behind does not have enough memory
> > assigned to it (ff500000-ff5fffff : PCI Bus #02).
> 
> Sounds familiar.  There are lots of cases where bridge windows aren't 
> allocated properly so devices behind them are invisible or can't work.  
> Check out the attached patch from Ivan, if you 
> pass 'pci=assign-bus-resources' to your kernel at boot time, the code will 
> try to reallocate bridge space for you if needed.

No, it won't help. The 1M range (ff500000-ff5fffff) is more than enough.
The reason why the D-Link resource is not getting assigned is rather
interesting: as Wayne wrote

> Here is the D-LINK NIC:
> # od -t x4 /sys/devices/pci0000:00/0000:00:14.4/0000:02:02.0/config
> 
> 0000000 49011186 80b00117 00000011 00004010
			    ^^^^^^
which means that the device class is 0 (not defined).
And in drivers/pci/setup-bus.c we have

		/* Don't touch classless devices or host bridges or ioapics.  */
		if (class == PCI_CLASS_NOT_DEFINED ||
		    class == PCI_CLASS_BRIDGE_HOST)
			continue;

The short term fix would be to assign proper device class to D-Link NIC
using pci quirk, but I believe a proper solution is to remove all sorts of
"if (class == PCI_xxx)" limitations (alpha, for example needs none of them)
from generic code and mark critical stuff with IORESOURCE_PCI_FIXED
in arch-specific way...

Ivan.

  reply	other threads:[~2007-05-23  9:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-22  1:42 System Design Works
2007-05-22  2:03 ` Jesse Barnes
2007-05-22  2:36   ` Wayne Sherman
2007-05-22 15:58     ` Jesse Barnes
2007-05-22 23:21       ` Wayne Sherman
2007-05-22 23:31         ` Jesse Barnes
2007-05-23  9:26           ` Ivan Kokshaysky [this message]
2007-05-24  0:20             ` Wayne Sherman
2007-05-24  3:08               ` Jesse Barnes
2007-05-24  3:10                 ` Jesse Barnes
2007-05-24 10:09                   ` Ivan Kokshaysky
2007-05-25  0:27                     ` Wayne Sherman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070523132634.A16545@jurassic.park.msu.ru \
    --to=ink@jurassic.park.msu.ru \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsherman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®