From: Randy Dunlap <randy.dunlap@oracle.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: akpm <akpm@linux-foundation.org>,
rene.herman@gmail.com, mjt@tls.msk.ru,
Jan Engelhardt <jengelh@linux01.gwdg.de>
Subject: [PATCH] use printk.time option, drop time/notime
Date: Thu, 24 May 2007 17:15:35 -0700 [thread overview]
Message-ID: <20070524171535.329ea2c0.randy.dunlap@oracle.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0705241832500.31549@yvahk01.tjqt.qr>
From: Randy Dunlap <randy.dunlap@oracle.com>
Andrew, please drop add-notime-boot-option.patch
and use this patch instead...
Allow printk_time to be enabled or disabled at boot time.
Previously it could be enabled only, but not disabled.
Change printk_time from an int to a bool since that's what it is.
Make its logical (exposed) name just be "time" (was "printk_time").
Note: Changes kernel boot option syntax from "time" to "printk.time=value".
Since printk_time is declared as a module_param, it can also be
changed at run-time by modifying
/sys/module/printk/parameters/time
to a value of 1/Y/y to enabled it or 0/N/n to disable it.
Since printk_time is declared as a module_param, its value can also
be set at boot-time by using
linux printk.time=<bool>
Drop the "time" boot option and its __setup() functions.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
Documentation/kernel-parameters.txt | 5 +++--
kernel/printk.c | 12 +-----------
2 files changed, 4 insertions(+), 13 deletions(-)
--- linux-2622-rc2g5.orig/Documentation/kernel-parameters.txt
+++ linux-2622-rc2g5/Documentation/kernel-parameters.txt
@@ -1406,6 +1406,9 @@ and is between 256 and 4096 characters.
autoconfiguration.
Ranges are in pairs (memory base and size).
+ printk.time= Show timing data prefixed to each printk message line
+ Format: <bool> (1/Y/y=enable, 0/N/n=disable)
+
profile= [KNL] Enable kernel profiling via /proc/profile
Format: [schedule,]<number>
Param: "schedule" - profile schedule points.
@@ -1805,8 +1808,6 @@ and is between 256 and 4096 characters.
thash_entries= [KNL,NET]
Set number of hash buckets for TCP connection
- time Show timing data prefixed to each printk message line
-
clocksource= [GENERIC_TIME] Override the default clocksource
Override the default clocksource and use the clocksource
with the name specified.
--- linux-2622-rc2g5.orig/kernel/printk.c
+++ linux-2622-rc2g5/kernel/printk.c
@@ -449,17 +449,7 @@ static int printk_time = 1;
#else
static int printk_time = 0;
#endif
-module_param(printk_time, int, S_IRUGO | S_IWUSR);
-
-static int __init printk_time_setup(char *str)
-{
- if (*str)
- return 0;
- printk_time = 1;
- return 1;
-}
-
-__setup("time", printk_time_setup);
+module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR);
__attribute__((weak)) unsigned long long printk_clock(void)
{
next prev parent reply other threads:[~2007-05-25 0:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 19:09 [PATCH] add "notime" boot option Randy Dunlap
2007-05-22 19:40 ` Dave Jones
2007-05-22 20:00 ` Randy Dunlap
2007-05-23 11:03 ` Michael Tokarev
2007-05-23 17:04 ` Randy Dunlap
2007-05-23 19:15 ` Rene Herman
2007-05-23 20:55 ` Randy Dunlap
2007-05-24 4:54 ` Rene Herman
2007-05-24 5:08 ` Randy Dunlap
2007-05-24 5:11 ` Rene Herman
2007-05-24 6:29 ` Rene Herman
2007-05-24 16:13 ` Jan Engelhardt
2007-05-24 16:24 ` Randy Dunlap
2007-05-24 16:33 ` Jan Engelhardt
2007-05-25 0:15 ` Randy Dunlap [this message]
2007-05-29 20:07 ` [PATCH] use printk.time option, drop time/notime Andrew Morton
2007-05-29 21:28 ` Jan Engelhardt
2007-05-30 18:37 ` [PATCH v3] add printk.time option, deprecate 'time' Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070524171535.329ea2c0.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=rene.herman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome