mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qi Yong <qiyong@fc-cn.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Diego Calleja <diegocg@gmail.com>, Qi Yong <qiyong@fc-cn.com>,
	"Valdis.Kletnieks@vt.edu" <Valdis.Kletnieks@vt.edu>,
	"Robert P. J. Day" <rpjday@mindspring.com>,
	debian developer <debiandev@gmail.com>,
	greg@kroah.com, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH - 1/1] Documentation/HOWTO
Date: Fri, 25 May 2007 03:13:49 -0400	[thread overview]
Message-ID: <20070525071349.GA28425@denali.sosdg.org> (raw)
In-Reply-To: <alpine.LFD.0.98.0705240847160.26602@woody.linux-foundation.org>

On Thu, May 24, 2007 at 08:49:12AM -0700, Linus Torvalds wrote:
> 
> 
> On Thu, 24 May 2007, Diego Calleja wrote:
> > El Thu, 24 May 2007 17:45:04 +0800, "Qi Yong" <qiyong@fc-cn.com> escribió:
> > 
> > D'oh, it seems the patch was picked from the mailing list and merged twice,
> > and I didn't notice it.
> > 
> > > Torvalds, Care to revert one commit?
> > 
> > Agreed, one of them can be removed.
> 
> Yes, done.
> 
> Andrew - can you check that it's also removed from your queues, since it 
> might be there still just because it keeps applying cleanly.

People's fault, not tools'.

> 
> You might have it described as "HOWTO: mention bughunting" rather than 
> "HOWTO: bug report addition".
> 
> 		Linus

Sorry, my previous comment was not accurate.  The two patches are different,
not identical:


diff -u howto-mention-bughunting howto-bug-report-addition 
--- howto-mention-bughunting	2007-05-25 09:12:47.513596296 +0800
+++ howto-bug-report-addition	2007-05-25 09:12:58.914245983 +0800
@@ -1,7 +1,7 @@
 --- a/Documentation/HOWTO
 +++ b/Documentation/HOWTO
-@@ -375,6 +375,26 @@ of information is needed by the kernel developers to help track down the
- problem.
+@@ -395,6 +395,26 @@ bugme-janitor mailing list (every change in the bugzilla is mailed here)
+ 
  
  
 +Managing bug reports
@@ -11,7 +11,7 @@
 +bugs reported by other people. Not only you will help to make the kernel
 +more stable, you'll learn to fix real world problems and you will improve
 +your skills, and other developers will be aware of your presence. Fixing
-+bugs is one of the best ways to earn merit amongst the developers, because
++bugs is one of the best ways to get merits among other developers, because
 +not many people like wasting time fixing other people's bugs.
 +
 +To work in the already reported bug reports, go to http://bugzilla.kernel.org.


The second patch howto-bug-report-addition was an improvement, but was made
wrongly, thus added the duplication.

We should go with howto-bug-report-addition. Please take this:

Signed-off-by: Qi Yong <qiyong@fc-cn.com>
---

diff --git a/Documentation/HOWTO b/Documentation/HOWTO
index ced9207..f5e1b6d 100644
--- a/Documentation/HOWTO
+++ b/Documentation/HOWTO
@@ -383,7 +383,7 @@ One of the best ways to put into practice your hacking skills is by fixing
 bugs reported by other people. Not only you will help to make the kernel
 more stable, you'll learn to fix real world problems and you will improve
 your skills, and other developers will be aware of your presence. Fixing
-bugs is one of the best ways to earn merit amongst the developers, because
+bugs is one of the best ways to get merits among other developers, because
 not many people like wasting time fixing other people's bugs.
 
 To work in the already reported bug reports, go to http://bugzilla.kernel.org.


-- 
Qi Yong


      parent reply	other threads:[~2007-05-25  7:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-18 13:29 debian developer
2007-05-18 14:01 ` Pekka Enberg
2007-05-18 16:01 ` Robert P. J. Day
2007-05-18 16:37   ` Bernd Eckenfels
2007-05-25 16:24     ` Scott Preece
2007-05-25 20:00       ` Bernd Eckenfels
2007-05-18 17:26   ` Valdis.Kletnieks
2007-05-24  9:45     ` Qi Yong
2007-05-24 11:56       ` Diego Calleja
2007-05-24 15:49         ` Linus Torvalds
2007-05-24 16:28           ` debian developer
2007-05-25  7:13           ` Qi Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070525071349.GA28425@denali.sosdg.org \
    --to=qiyong@fc-cn.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=debiandev@gmail.com \
    --cc=diegocg@gmail.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@mindspring.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®