From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: <schwidefsky@de.ibm.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, "NeilBrown" <neilb@suse.de>,
"linux-s390" <linux-s390@vger.kernel.org>
Subject: Re: 2.6.22-rc1-mm1 - s390 vs. md
Date: Fri, 25 May 2007 08:02:51 +0200 [thread overview]
Message-ID: <20070525080251.1bca37ee@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <0C7297FA1D2D244A9C7F6959C0BF1E5201E703A5@azsmsx413.amr.corp.intel.com>
On Thu, 24 May 2007 15:11:08 -0700,
"Williams, Dan J" <dan.j.williams@intel.com> wrote:
> --- a/async_tx/async_memcpy.c
> +++ b/async_tx/async_memcpy.c
> @@ -56,6 +56,7 @@ async_memcpy(struct page *dest, struct page *src,
> unsigned int dest_offset,
> int_en) : NULL;
>
> if (tx) { /* run the memcpy asynchronously */
> + #ifdef CONFIG_HAS_DMA
> dma_addr_t dma_addr;
> enum dma_data_direction dir;
Can you factor out the async stuff into a function so you can use the
#ifdefs to define different functions rather than put them in the middle
of a complex function?
(Maybe you should rather use #ifdef CONFIG_DMA_ENGINE, since the async
part is not needed for !DMA_ENGINE either.)
next prev parent reply other threads:[~2007-05-25 6:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 6:36 Williams, Dan J
2007-05-18 5:39 ` Cornelia Huck
2007-05-18 16:30 ` Williams, Dan J
2007-05-21 7:24 ` Cornelia Huck
2007-05-21 8:52 ` Williams, Dan J
2007-05-23 0:25 ` Williams, Dan J
2007-05-23 8:05 ` Martin Schwidefsky
2007-05-23 8:46 ` Cornelia Huck
2007-05-23 8:55 ` Martin Schwidefsky
2007-05-24 22:11 ` Williams, Dan J
2007-05-25 6:02 ` Cornelia Huck [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-05-16 3:19 2.6.22-rc1-mm1 Andrew Morton
2007-05-16 7:57 ` 2.6.22-rc1-mm1 - s390 vs. md Cornelia Huck
2007-05-16 17:21 ` Williams, Dan J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525080251.1bca37ee@gondolin.boeblingen.de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=neilb@suse.de \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®