From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757384AbXEYLmr (ORCPT ); Fri, 25 May 2007 07:42:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751336AbXEYLml (ORCPT ); Fri, 25 May 2007 07:42:41 -0400 Received: from smtp-105-friday.noc.nerim.net ([62.4.17.105]:3193 "EHLO mallaury.nerim.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751075AbXEYLmk (ORCPT ); Fri, 25 May 2007 07:42:40 -0400 Date: Fri, 25 May 2007 13:43:44 +0200 From: Jean Delvare To: "Pekka Enberg" Cc: LKML , "Andrew Morton" Subject: Re: [PATCH] tty_io: Use kzalloc Message-ID: <20070525134344.0f93e797@hyperion.delvare> In-Reply-To: <84144f020705250345x4faa23f7kc6276017285357e8@mail.gmail.com> References: <20070525124258.5b72f077@hyperion.delvare> <84144f020705250345x4faa23f7kc6276017285357e8@mail.gmail.com> X-Mailer: Sylpheed-Claws 2.5.5 (GTK+ 2.10.6; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 May 2007 13:45:58 +0300, Pekka Enberg wrote: > Hi Jean, > > On 5/25/07, Jean Delvare wrote: > > - ltp = (struct ktermios *) kmalloc(sizeof(struct ktermios), > > + ltp = (struct ktermios *) kzalloc(sizeof(struct ktermios), > > GFP_KERNEL); > > When doing conversions like this, please drop the redundant casts too. Good point, sorry for overlooking this. Updated patch follows. -- Jean Delvare