mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jengelh@linux01.gwdg.de
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Linux always started with 9600 8N1
Date: Sun, 27 May 2007 14:47:02 -0700 (PDT)	[thread overview]
Message-ID: <20070527.144702.55507425.davem@davemloft.net> (raw)
In-Reply-To: <20070527.141622.30184020.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Sun, 27 May 2007 14:16:22 -0700 (PDT)

> So even writes to so-called 'read-only' sections of the kernel image
> will work and therefore I don't understand what the bug could be other
> than the compiler "optimizing" away the write to the constant string
> in which case the compiler should have warned about it.

I just stared at the drivers/serial/suncore.s assembler a little
bit and this is indeed what appears to be happening, the compiler
is optimizing the stores away completely yet not doing so much
as emitting a warning, how rude :-)

Perhaps there is some warning option that isn't enabled which
would have caught this...

Thanks a lot for your patch, I'll apply it.

  reply	other threads:[~2007-05-27 21:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.61.0705261649590.7344@yvahk01.tjqt.qr>
     [not found] ` <20070526.154745.30164056.davem@davemloft.net>
2007-05-27 16:44   ` Jan Engelhardt
2007-05-27 17:09     ` Jan Engelhardt
2007-05-27 21:16     ` David Miller
2007-05-27 21:47       ` David Miller [this message]
2007-05-29 20:10         ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070527.144702.55507425.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®