Re: [PATCH 1/4] Make usb-autosuspend timer 1 sec jiffy aligned

[Randy Dunlap <randy.dunlap@oracle.com>]

On Tue, 29 May 2007 10:58:21 -0700 Venki Pallipadi wrote:

> 
> 
> Below are a bunch of random timers, that were active on my system,
> that can better be round_jiffies() aligned.

and these 4 patches help with (a) power usage, or (b) cache
usage/niceness, or (c) other (be specific)...

Thanks.

> I guess we need a audit of all timer usages atleast in kernel-core.
> 
> This patch:
> 
> Make usb autosuspend timers 1sec jiffy aligned.
> 
> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> 
> Index: linux-2.6.22-rc-mm/drivers/usb/core/driver.c
> ===================================================================
> --- linux-2.6.22-rc-mm.orig/drivers/usb/core/driver.c	2007-05-24 11:16:00.000000000 -0700
> +++ linux-2.6.22-rc-mm/drivers/usb/core/driver.c	2007-05-25 10:00:50.000000000 -0700
> @@ -974,7 +974,7 @@
>  			 * or for the past.
>  			 */
>  			queue_delayed_work(ksuspend_usb_wq, &udev->autosuspend,
> -					suspend_time - jiffies);
> +				round_jiffies_relative(suspend_time - jiffies));
>  			}
>  		return -EAGAIN;
>  	}
> -

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***