From: Wang Zhenyu <zhenyu.z.wang@intel.com>
To: Christoph Hellwig <hch@infradead.org>,
Dave Jones <davej@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Keith Packard <keithp@keithp.com>, Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH 2/2] [AGPGART] intel_agp: use table for device probe
Date: Tue, 29 May 2007 21:41:34 +0800 [thread overview]
Message-ID: <20070529134134.GA11026@zhen-devel.sh.intel.com> (raw)
In-Reply-To: <20070529091848.GB27950@infradead.org>
On 2007.05.29 10:18:48 +0000, Christoph Hellwig wrote:
> On Tue, May 29, 2007 at 02:21:25PM +0800, Wang Zhenyu wrote:
> > +static const struct intel_driver_description {
> > + unsigned int chip_id;
> > + unsigned int gmch_chip_id;
> > + char *name;
> > + struct agp_bridge_driver *driver;
> > + struct agp_bridge_driver *gmch_driver;
>
> The two should be const to avoid the silly casts below.
>
> > + for (i = 0; intel_agp_chipsets[i].name != NULL; i++) {
> > + if (pdev->device == intel_agp_chipsets[i].chip_id)
> > + break;
>
> please use tabs for indentation.
>
I'll fix those problems in next submit, thank you for review.
prev parent reply other threads:[~2007-05-29 13:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 6:21 Wang Zhenyu
2007-05-29 9:18 ` Christoph Hellwig
2007-05-29 13:41 ` Wang Zhenyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070529134134.GA11026@zhen-devel.sh.intel.com \
--to=zhenyu.z.wang@intel.com \
--cc=davej@redhat.com \
--cc=eric@anholt.net \
--cc=hch@infradead.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®