mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	Andy Whitcroft <apw@shadowen.org>, Andrew Morton <akpm@osdl.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Joel Schopp <jschopp@austin.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add a trivial patch style checker
Date: Tue, 29 May 2007 16:58:18 +0200	[thread overview]
Message-ID: <20070529145818.GB5024@one.firstfloor.org> (raw)
In-Reply-To: <20070529142222.GC18437@osiris.boeblingen.de.ibm.com>

> So you prefer random data corruption over an emergency stop?

With an oops you can at least recover the system and actually 
look at the problem. On a machine with a panic you're just dead
and the probability of actually being able to do something about the problem
is much lower. On x86 systems you typically don't even get 
any message out.

And I'm not convinced drivers are in a good position to decide
if memory was likely corrupted or not anyways. At least the
panics I see in driver sources seem to be just random logic
bugs from someone not familiar with BUG().

Also they typically don't make much attempt to figure out
if there might have been data corruption.

If you're really worried about memory corruption in drivers
you should just use an IOMMU.

> That doesn't make much sense to me...

So you're always setting panic_on_oops? 

-Andi


  reply	other threads:[~2007-05-30  9:39 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-27 17:11 Andy Whitcroft
2007-05-27 17:10 ` Randy Dunlap
2007-05-28 10:48   ` Andy Whitcroft
2007-05-29 15:00   ` Joel Schopp
2007-05-27 17:49 ` Andreas Schwab
2007-05-27 21:49 ` Dave Jones
2007-05-28  0:18 ` Andrew Morton
2007-05-28 12:10   ` Andy Whitcroft
2007-05-28  9:13 ` Sam Ravnborg
2007-05-28  9:45 ` Jan Engelhardt
2007-05-29  9:01   ` Andy Whitcroft
2007-05-29 16:12     ` Joel Schopp
2007-05-29 16:20       ` Julio M. Merino Vidal
2007-05-29 20:00     ` Jan Engelhardt
2007-05-29  1:51 ` Qi Yong
2007-05-29  2:23 ` Andi Kleen
2007-05-29  9:05   ` Andy Whitcroft
2007-05-29 20:22     ` Jan Engelhardt
2007-05-29 22:36       ` Randy Dunlap
2007-05-30  8:34         ` Jan Engelhardt
2007-05-30 15:33           ` Randy Dunlap
2007-05-30 16:04             ` Jan Engelhardt
2007-05-31 12:07     ` [PATCH] add a trivial patch style checker II Andi Kleen
2007-05-31 19:59       ` Dave Jones
2007-06-01 14:18         ` Andy Whitcroft
2007-05-29 11:53   ` [PATCH] add a trivial patch style checker Heiko Carstens
2007-05-29 13:19     ` Andi Kleen
2007-05-29 14:22       ` Heiko Carstens
2007-05-29 14:58         ` Andi Kleen [this message]
2007-05-29 16:43           ` Heiko Carstens
2007-05-29 23:21             ` Andi Kleen
2007-05-29 18:55   ` Andy Whitcroft
2007-05-29 21:07 ` [PATCH] add a trivial patch style checker v2 Andy Whitcroft
2007-05-29 22:42   ` Joel Schopp
2007-06-06 12:40   ` Geert Uytterhoeven
2007-06-06 15:04     ` Dave Jones
2007-06-06 18:35     ` Andy Whitcroft
2007-05-31 19:26 ` [PATCH] add a trivial patch style checker Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070529145818.GB5024@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=akpm@osdl.org \
    --cc=apw@shadowen.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jschopp@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®