From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Robin Holt <holt@sgi.com>
Cc: Stephane Eranian <eranian@frankl.hpl.hp.com>,
linux-kernel@vger.kernel.org, eranian@hpl.hp.com
Subject: Re: [PATCH 02/22] 2.6.22-rc3 perfmon2 : generic kernel modifications
Date: Wed, 30 May 2007 23:42:06 +1000 [thread overview]
Message-ID: <20070530234206.ae2bec8d.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20070530113403.GA14480@lnx-holt.americas.sgi.com>
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Wed, 30 May 2007 06:34:03 -0500 Robin Holt <holt@sgi.com> wrote:
>
> That breaks git-bisect. Just introducing new text, but not actually using
> it makes it appear to somebody using git-bisect to identify the source of
> a problem as though all the changes came in at the same time. Bad idea.
But the patch set as it is includes references to files that do not exist
and so breaks the build.
Ideally, you would introduce references to files as the files are
introduced. I was suggesting a simpler reordering of the patches.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-05-30 13:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 13:48 Stephane Eranian
2007-05-29 14:46 ` Stephen Rothwell
2007-05-30 11:34 ` Robin Holt
2007-05-30 13:42 ` Stephen Rothwell [this message]
2007-05-30 13:56 ` Stephane Eranian
2007-06-04 15:13 ` David Rientjes
2007-06-07 8:18 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070530234206.ae2bec8d.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=eranian@frankl.hpl.hp.com \
--cc=eranian@hpl.hp.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®