Re: [PATCH 03/22] 2.6.22-rc3 perfmon2 : new system calls support

[Stephane Eranian <eranian@hpl.hp.com>]

Christoph,

On Thu, May 31, 2007 at 04:21:34PM +0100, Christoph Hellwig wrote:
> On Tue, May 29, 2007 at 06:48:17AM -0700, Stephane Eranian wrote:
> > sys_pfm_create_context():
> > 	- create a new perfmon2 context and returns a file descriptor in
> > 	  the pfarg_ctx_t parameters. This is the first call an application
> > 	  must make to do monitoring 
> > 	- rewritten to pass sampling format identification as a string
> > 	- file descriptor is now returned by call
> > 
> > sys_pfm_write_pmcs():
> > 	- program the PMU configuration registers. Accepts vector of arguments
> > 	  of type pfarg_pmc_t
> > 	
> > sys_pfm_write_pmds():
> > 	- program the PMU data registers. Accepts a vector of arguments of type
> > 	  pfarg_pmd_t
> > 
> > sys_pfm_read_pmds():
> > 	- read the PMU data registers.  Accepts a vector of arguments of type
> > 	  pfarg_pmd_t
> 
> This kind of interface doesn't make any sense at all.  Information should
> be read and written from filedescriptors using the read and write family
> syscalls and through the VFS instead of adding tons of system calls.
> 

They are all using file descriptors already.
We use read() for receiving overflow notifications. Write is not used.

> I fear we need to write down the requirements first and then come up
> with something better.  E.g. for per-task sampling an interface centered
> around a few files in /proc/<pid>/ would fit very nicely:
> 
>   /proc/<pid>/perfmon_pmcs
>   /proc/<pid>/perfmon_pmds
>   	Obvious
>   /proc/<pid>/perfmon_ctl
>   	Can get control commands as ascii sets written to
> 
You don't want to do parsing because usually, when sampling, you have
to reprogram the registers on the fly and this is on the critical path.
Information has to be exchanged in binary format.

-- 

-Stephane