From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu,
torvalds@linux-foundation.org, Chris Zankel <chris@zankel.net>
Subject: Re: [PATCH] Introduce O_CLOEXEC (take >2)
Date: Fri, 1 Jun 2007 11:38:40 +1000 [thread overview]
Message-ID: <20070601113840.813463db.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20070531162021.4cd4e91a.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 991 bytes --]
On Thu, 31 May 2007 16:20:21 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > diff --git a/include/asm-generic/fcntl.h b/include/asm-generic/fcntl.h
> > index c154b9d..b847741 100644
> > --- a/include/asm-generic/fcntl.h
> > +++ b/include/asm-generic/fcntl.h
> > @@ -48,6 +48,9 @@
> > #ifndef O_NOATIME
> > #define O_NOATIME 01000000
> > #endif
> > +#ifndef O_CLOEXEC
> > +#define O_CLOEXEC 02000000 /* set close_on_exec */
> > +#endif
> > #ifndef O_NDELAY
> > #define O_NDELAY O_NONBLOCK
> > #endif
>
> This will break xtensa, because that architecture (and only that
> architecture) doesn't include asm-generic/fcntl.h from asm/fcntl.h.
This also breaks Alpha (which uses 02000000 for O_DIRECT) and parisc
(which uses 02000000 for O_RSYNC). So you ether need to choose a
different value or define O_CLOEXEC for those two architectures.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-06-01 1:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 18:09 Ulrich Drepper
2007-05-31 18:22 ` Nicholas Miell
2007-05-31 18:32 ` Ulrich Drepper
2007-05-31 18:35 ` Davide Libenzi
2007-05-31 18:42 ` Ulrich Drepper
2007-05-31 18:46 ` Davide Libenzi
2007-05-31 18:53 ` Ulrich Drepper
2007-05-31 19:02 ` Jakub Jelinek
2007-05-31 19:17 ` Davide Libenzi
2007-05-31 19:50 ` Ulrich Drepper
2007-05-31 20:23 ` Davide Libenzi
2007-05-31 19:59 ` Linus Torvalds
2007-05-31 23:20 ` Andrew Morton
2007-06-01 1:05 ` Stephen Rothwell
2007-06-01 1:38 ` Stephen Rothwell [this message]
2007-06-01 3:07 ` Kyle McMartin
2007-06-01 19:17 ` Byron Stanoszek
2007-06-01 22:55 ` Kyle McMartin
2007-06-10 2:29 ` dean gaudet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070601113840.813463db.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=chris@zankel.net \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®