mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: "John Anthony Kazos Jr." <jakj@j-a-k-j.com>
Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>,
	Dave Jones <davej@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch 1/1] document Acked-by:
Date: Sat, 2 Jun 2007 21:07:40 +0200	[thread overview]
Message-ID: <20070602190740.GB10768@uranus.ravnborg.org> (raw)
In-Reply-To: <alpine.DEB.0.99.0706021357070.24195@sigma.j-a-k-j.com>

On Sat, Jun 02, 2007 at 02:00:00PM -0400, John Anthony Kazos Jr. wrote:
> > > > >  > Explain what we use Acked-by: for, and how it differs from Signed-off-by:
> > > > >  > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > > > >  > +
> > > > >  > +If a person was not directly involved in the preparation or handling of a
> > > > >  > +patch but wishes to signify and record their approval of it then they can
> > > > >  > +arrange to have an Acked-by: line added to the patch's changelog.
> > > > > 
> > > > > Acked-by: Dave Jones <davej@redhat.com>
> > > > 
> > > > What, no Tested-by: ?
> > >
> > >Heh. Indeed.  I think there's room for both fwiw.
> > 
> > Too verbose. Suggest a typedef.
> > 
> > 	Signed-off-and-tested-by: Foo J. Bar <addy@corps>
> 
> Signed-off-by: should imply Tested-by:, with the exception of the final 
> Signed-off-by: when it's merged into a tree.
Subsystem maintainers cannot test each and every submission.
Sometimes due to lack of HW at other times simply due to lack of time.

Signed-off-by is exactly one thing - a way to show the path
a patch take. Then people on the path may have done more or less review/test.

Lot's of people confuses signed-of-by with acked-by btw - but this is waht this
patch should correct.

	Sam

  reply	other threads:[~2007-06-02 19:06 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-01  2:09 akpm
2007-06-01  5:32 ` Valdis.Kletnieks
2007-06-01  6:10   ` H. Peter Anvin
2007-06-01 10:53     ` John Anthony Kazos Jr.
2007-06-01 19:27       ` Krzysztof Halasa
2007-06-01 19:37         ` Scott Preece
2007-06-01 20:00           ` Andrew Morton
2007-06-01 20:04             ` Andrew Morton
2007-06-02 13:34               ` debian developer
2007-06-02 17:13                 ` Jan Engelhardt
2007-06-02 19:34                 ` Valdis.Kletnieks
2007-06-01 22:10           ` Krzysztof Halasa
2007-06-01 22:17             ` H. Peter Anvin
2007-06-01 22:42               ` Krzysztof Halasa
2007-06-02  0:37                 ` John Anthony Kazos Jr.
2007-06-02  0:56                   ` Krzysztof Halasa
2007-06-02  1:36             ` Valdis.Kletnieks
2007-06-01 17:27     ` Valdis.Kletnieks
2007-06-01 17:35       ` Andrew Morton
2007-06-01 18:14 ` Dave Jones
2007-06-01 18:22   ` Andrew Morton
2007-06-01 18:28     ` Dave Jones
2007-06-02 17:17       ` Jan Engelhardt
2007-06-02 18:00         ` John Anthony Kazos Jr.
2007-06-02 19:07           ` Sam Ravnborg [this message]
2007-06-02 14:11 ` Adrian Bunk
2007-06-02 17:47   ` Andrew Morton
2007-06-02 17:55     ` Adrian Bunk
2007-06-03  0:23     ` Krzysztof Halasa
2007-06-03  2:57     ` Scott Preece
2007-06-03  4:06       ` Randy Dunlap
2007-06-03  4:15         ` Andrew Morton
2007-06-03 18:31           ` Scott Preece

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070602190740.GB10768@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=davej@redhat.com \
    --cc=jakj@j-a-k-j.com \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®