mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	davem@davemloft.net
Subject: Re: [ATA]: Don't allow to enable this for SPARC64 without PCI.
Date: Mon, 4 Jun 2007 17:09:52 -0400	[thread overview]
Message-ID: <20070604210952.GI20299@havoc.gtf.org> (raw)
In-Reply-To: <200706042059.l54Kx6jR031700@hera.kernel.org>

On Mon, Jun 04, 2007 at 08:59:06PM +0000, Linux Kernel Mailing List wrote:
> Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=899b69d079713d0f568fb2700b86987aa94f29b2
> Commit:     899b69d079713d0f568fb2700b86987aa94f29b2
> Parent:     e11a6c236b3070ed05b079f91a9b3defa48b54d3
> Author:     David S. Miller <davem@sunset.davemloft.net>
> AuthorDate: Sun Jun 3 17:39:56 2007 -0700
> Committer:  David S. Miller <davem@sunset.davemloft.net>
> CommitDate: Sun Jun 3 18:09:42 2007 -0700
> 
>     [ATA]: Don't allow to enable this for SPARC64 without PCI.
>     
>     Based upon a report from Meelis Roos.
>     
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
>  drivers/ata/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index b4a8d60..7d893a6 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -8,6 +8,7 @@ menuconfig ATA
>  	depends on BLOCK
>  	depends on !(M32R || M68K) || BROKEN
>  	depends on !SUN4 || BROKEN
> +	depends on !(SPARC64 && !PCI)
>  	select SCSI

Um, this was NAK'd:

libata uses generic DMA and generic struct device.  Neither of which
are specific to SPARC64 or PCI.

Did you read the code?
Did you read the thread on which you were CC'd?
Did you see the NAKs from me and Alan (and others)?

	Jeff




       reply	other threads:[~2007-06-04 21:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200706042059.l54Kx6jR031700@hera.kernel.org>
2007-06-04 21:09 ` Jeff Garzik [this message]
2007-06-04 21:27   ` David Miller
2007-06-04 21:58     ` Jeff Garzik
2007-06-04 22:03       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070604210952.GI20299@havoc.gtf.org \
    --to=jeff@garzik.org \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®