mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Richard Purdie <rpurdie@openedhand.com>
Cc: Nitin Gupta <nitingupta910@gmail.com>,
	Daniel Hazelton <dhazelton@enter.net>,
	akpm <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Hugh Dickins <hugh@veritas.com>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH -mm 0/5] LZO and swap write failure patches for -mm
Date: Tue, 5 Jun 2007 07:15:22 +0100	[thread overview]
Message-ID: <20070605061522.GB25760@infradead.org> (raw)
In-Reply-To: <1180990731.6313.179.camel@localhost.localdomain>

On Mon, Jun 04, 2007 at 09:58:51PM +0100, Richard Purdie wrote:
> On Mon, 2007-06-04 at 23:56 +0530, Nitin Gupta wrote:
> > Yes there might still be problems - that is why I posted as RFC. I got
> > useful comments and the code is improving. Going for such fork might
> > be pain initially but IMHO its worth it. My idea for this 'fork' is
> > not just clean-ups but potential optimizations that such cleanups
> > usually bring along. I do not think there will be major overhauls in
> > such mature de/compression implementations so I believe its okay to go
> > for such 'fork' for sake of cleaner and perhaps faster code.
> 
> If you want to make cleaner and faster code, why not work on LZO
> upstream directly? I'm sure the LZO author would welcome the speedups,
> just as much as the kernel would. 

Because it's author has shown his preference for crappy code.  Can we
please stop this stupid 'upstream' term here?  LZO is first and most
and algorithm.  There is a really crappy reference implementation, but
we should not put that in but rather have a proper implementation targeted
at the linux kernel.  Whether that implementation starts from scratch or
by gradually improving the existing reference implementation doesn't matter.


      reply	other threads:[~2007-06-05  6:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-04 15:36 Richard Purdie
2007-06-04 16:14 ` Daniel Hazelton
2007-06-04 16:52   ` Richard Purdie
2007-06-04 17:37     ` Daniel Hazelton
2007-06-04 18:34       ` Nitin Gupta
2007-06-04 20:45       ` Richard Purdie
2007-06-04 22:13         ` Daniel Hazelton
2007-06-04 18:26     ` Nitin Gupta
2007-06-04 20:06       ` Adrian Bunk
2007-06-05  5:30         ` Nitin Gupta
2007-06-05  5:50           ` Andrew Morton
2007-06-05  8:56             ` Richard Purdie
2007-06-04 20:58       ` Richard Purdie
2007-06-05  6:15         ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070605061522.GB25760@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=dhazelton@enter.net \
    --cc=dwmw2@infradead.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=nitingupta910@gmail.com \
    --cc=rpurdie@openedhand.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®