mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-pm@lists.linux-foundation.org,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: Linux 2.6.22-rc4
Date: Tue, 5 Jun 2007 22:19:54 +0200	[thread overview]
Message-ID: <20070605201954.GB4424@elf.ucw.cz> (raw)
In-Reply-To: <20070605193718.GB24877@elte.hu>

Hi!

> > > [ 116.733327] PM: suspend-to-disk mode set to 'shutdown' [ 
> > > 116.738849] swsusp: Basic memory bitmaps created [ 116.745353] 
> > > Stopping tasks ... WARNING: at 
> > > /home/devel/linux-git/kernel/lockdep.c:2414 check_flags()
> 
> > > [  116.755052] irq event stamp: 69
> > > [  116.755060] hardirqs last  enabled at (69): [<c04040f9>] syscall_exit_work+0x11/0x26
> > > [  116.755084] hardirqs last disabled at (68): [<c0403fdd>] syscall_exit+0x9/0x1a
> > > [  116.755109] softirqs last  enabled at (0): [<c042150c>] copy_process+0x4dd/0x1286
> > > [  116.755139] softirqs last disabled at (0): [<00000000>] 0x0
> > > [  116.945776] done.
> 
> > Well, it's harmless in the sense that "yeah, the system still works", 
> > but it does seem to be a real bug. We have hardware interrupts 
> > disabled when we _think_ we should have them on, so our irq tracking 
> > is off.
> > 
> > Ingo, do you see what's up? It looks like we got a signal to a process 
> > that just got created, is the setup stuff for "tsk->hardirqs_enabled" 
> > perhaps off a bit?
> 
> hm. I cannot see the source of the bug at the moment, but here's my 
> analysis so far:
> 
> the last event that irqtrace got was #69, and that was a 'hardirqs on' 
> in syscall_exit_work. After that we did a 'hardirqs off' without 
> properly tracking that via irqtrace. Next time we got an irqtrace event 
> (event 70) the assert caught up with us and turned off lockdep and 
> backed out of that function. This was in:
> 
>  > [  116.754957]  [<c043c3e5>] check_flags+0x95/0x143
>  > [  116.754967]  [<c043f158>] lock_acquire+0x29/0x82
>  > [  116.754977]  [<c06313a7>] _spin_lock+0x35/0x42
>  > [  116.754990]  [<c044894a>] refrigerator+0x14/0xc6
>  > [  116.755002]  [<c042d4b3>] get_signal_to_deliver+0x33/0x397
>  > [  116.755016]  [<c0403597>] do_notify_resume+0x94/0x6ed
>  > [  116.755029]  [<c0404099>] work_notifysig+0x13/0x1a
> 
> isnt the refrigerator() suspend related? Perhaps suspend disables irqs 
> somewhere that we forgot to track?

refrigerator is suspend related, but I do not think it does any
interrupt magic. We do magic later in hibernation process.

This is in kernel/power/process.c, we have spinlock_irqsave there, but
that's pretty much it AFAICT.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2007-06-05 20:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-05  3:50 Linus Torvalds
2007-06-05  9:29 ` David Greaves
2007-06-05 16:14 ` Linux 2.6.22-rc4 - sata_promise regression since -rc3 David Greaves
2007-06-05 18:54 ` Linux 2.6.22-rc4 Michal Piotrowski
2007-06-05 19:26   ` Linus Torvalds
2007-06-05 19:37     ` Ingo Molnar
2007-06-05 19:50       ` Linus Torvalds
2007-06-05 20:16         ` Pavel Machek
2007-06-05 20:19       ` Pavel Machek [this message]
2007-06-05 22:01         ` Rafael J. Wysocki
2007-06-07 14:46     ` Jan Engelhardt
2007-06-07 15:24       ` Gene Heskett
2007-06-07 15:38         ` Jan Engelhardt
2007-06-07 16:06           ` Gene Heskett
2007-06-07 16:54             ` Jan Engelhardt
2007-06-07 20:21               ` Gene Heskett
2007-06-07 21:14                 ` Pavel Machek
2007-06-05 21:11 ` Badari Pulavarty
2007-06-10  6:15 ` Avuton Olrich
2007-06-05 10:41 Mikael Pettersson
2007-06-05 15:51 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070605201954.GB4424@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®