From: Masatake YAMATO <jet@gyve.org>
To: cebbert@redhat.com
Cc: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] never called printk statement in ide-taskfile.c::wait_drive_not_busy
Date: Wed, 06 Jun 2007 02:35:58 +0900 (JST) [thread overview]
Message-ID: <20070606.023558.230059723.jet@gyve.org> (raw)
In-Reply-To: <4665988A.5060902@redhat.com>
> On 06/04/2007 10:21 PM, Masatake YAMATO wrote:
> > diff --git a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c
> > index 30175c7..5e05311 100644
> > --- a/drivers/ide/ide-taskfile.c
> > +++ b/drivers/ide/ide-taskfile.c
> > @@ -249,7 +249,7 @@ static u8 wait_drive_not_busy(ide_drive_t *drive)
> > while (((stat = hwif->INB(IDE_STATUS_REG)) & BUSY_STAT) && retries--)
> > udelay(10);
> >
> > - if (!retries)
> > + if (retries < 0)
>
> if (stat & BUSY_STAT)
>
> > printk(KERN_ERR "%s: drive still BUSY!\n", drive->name);
> >
Oh, yes.
Giving `retries' both roles: loop counter and condition flag for logging
may not good.
for (retries = 0; retries < 100; retries++)
{
if ((stat = hwif->INB(IDE_STATUS_REG)) & BUSY_STAT)
break;
udelay(10);
}
if (stat & BUSY_STAT)
printk(KERN_ERR "%s: drive still BUSY!\n", drive->name);
Masatake YAMATO
next prev parent reply other threads:[~2007-06-05 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 2:21 Masatake YAMATO
2007-06-05 17:08 ` Chuck Ebbert
2007-06-05 17:35 ` Masatake YAMATO [this message]
2007-06-15 22:45 ` Bartlomiej Zolnierkiewicz
2007-06-17 18:05 ` Masatake YAMATO
2007-06-21 19:56 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070606.023558.230059723.jet@gyve.org \
--to=jet@gyve.org \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=cebbert@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®