From: Alistair John Strachan <s0348365@sms.ed.ac.uk>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
akpm@osdl.org, linux-kernel@vger.kernel.org, jeff@garzik.org
Subject: Re: [PATCH] intel-rng: Undo mess made by an 80 column extremist
Date: Thu, 7 Jun 2007 22:32:36 +0100 [thread overview]
Message-ID: <200706072232.37051.s0348365@sms.ed.ac.uk> (raw)
In-Reply-To: <m3wsyfzcpt.fsf@maximus.localdomain>
On Thursday 07 June 2007 22:17:18 Krzysztof Halasa wrote:
> Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
> > The intel-rng printed a nice well formatted message when the port was
> > disabled. Someone then came along and blindly trashed it by screwing up a
> > trim down to 80 columns.
>
> Perhaps we should drop that 80-column style and use some 120+?
> X or no X, almost all people now have more lines and columns on their
> displays than MDA 20 years ago.
>
> 132 to match text VGA perhaps?
> 80 can be left for the actual _output_, I mean number of chars printed
> by kernel code.
I personally buy the argument that 80 cols helps remind people that they've
used too many indentation depths and should redesign their code. I think it's
a good thing to stick to where possible, even if just from a design
perspective.
There are some cases such as the one Alan has pointed out here where being
strictly 80 cols seems more destructive than useful, but those are the
exception, not the rule (IMO).
--
Cheers,
Alistair.
Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.
next prev parent reply other threads:[~2007-06-07 21:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-07 15:22 Alan Cox
2007-06-07 15:23 ` Jeff Garzik
2007-06-07 15:44 ` Alan Cox
2007-06-07 17:22 ` Jeff Garzik
2007-06-07 21:17 ` Krzysztof Halasa
2007-06-07 21:32 ` Alistair John Strachan [this message]
2007-06-07 22:06 ` Krzysztof Halasa
2007-06-08 1:08 ` H. Peter Anvin
2007-06-08 1:25 ` Jeff Garzik
2007-06-08 10:11 ` Peter Zijlstra
2007-06-09 20:33 ` Krzysztof Halasa
2007-06-07 22:32 ` Daniel Hazelton
2007-06-07 22:37 ` Krzysztof Halasa
2007-06-07 23:01 ` Daniel Hazelton
2007-06-07 22:46 ` Jesper Juhl
2007-06-07 23:04 ` Daniel Hazelton
2007-06-08 1:44 ` John Stoffel
2007-06-08 1:47 ` Jeff Garzik
2007-06-08 1:56 ` John Stoffel
2007-06-08 2:07 ` Jeff Garzik
2007-06-08 2:11 ` John Stoffel
2007-06-08 18:21 ` Ingo Oeser
2007-06-09 20:41 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706072232.37051.s0348365@sms.ed.ac.uk \
--to=s0348365@sms.ed.ac.uk \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®