From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031772AbXFHSsV (ORCPT ); Fri, 8 Jun 2007 14:48:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1031539AbXFHSru (ORCPT ); Fri, 8 Jun 2007 14:47:50 -0400 Received: from mx1.redhat.com ([66.187.233.31]:44963 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939216AbXFHSrs (ORCPT ); Fri, 8 Jun 2007 14:47:48 -0400 Date: Fri, 8 Jun 2007 11:48:35 -0700 From: Pete Zaitcev To: Greg KH Cc: "Robert P. J. Day" , USB development list , Chuck Ebbert , linux-kernel , zaitcev@redhat.com Subject: Re: blank filenames in /sys/modules, kernel 2.6.21 Message-Id: <20070608114835.7a5af390.zaitcev@redhat.com> In-Reply-To: <20070608183232.GA12967@kroah.com> References: <46699945.6020106@redhat.com> <20070608183232.GA12967@kroah.com> Organization: Red Hat, Inc. X-Mailer: Sylpheed 2.3.1 (GTK+ 2.10.11; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Jun 2007 11:32:32 -0700, Greg KH wrote: > > and from drivers/usb/core/usb.c: > > > > /* format to disable USB on kernel command line is: nousb */ > > __module_param_call("", nousb, param_set_bool, param_get_bool, &nousb, 0444); > Pete added that back in December of 2005 (git-blame rocks...). So what > has changed recently to cause this to do different things in sysfs? > > Robert, what do you suggest we change this usage to look like? Aww. I thought it was a nice patch, but my foresight was inadequate. The problem I tried to fix was related to strncmp used in the code which supported __setup(). Our installer, Anaconda, recognizes both "nousb" and "nousbstorage" - in theory. In practice, passing "nousbstorage" switched USB completely off because of improper strncmp(). If we back out my patch, this problem is going to reoccur. We might want to ask Jeremy Katz if "nousbstorage" is even used anymore, then revert all this if not. Or, we can add a name somehow and live with it visible in sysfs... -- Pete