mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
	Andi Kleen <ak@suse.de>, Arjan van de Ven <arjan@infradead.org>,
	Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
	Chris Wright <chrisw@sous-sol.org>
Subject: [patch-mm 11/23] hrtimer: speedup hrtimer_enqueue
Date: Sun, 10 Jun 2007 09:44:09 -0000	[thread overview]
Message-ID: <20070610092446.773377570@inhelltoy.tec.linutronix.de> (raw)
In-Reply-To: <20070610092437.118387863@inhelltoy.tec.linutronix.de>

[-- Attachment #1: hrtimer-speedup-enqueue.patch --]
[-- Type: text/plain, Size: 1543 bytes --]

From: Ingo Molnar <mingo@elte.hu>

Speedup hrtimer_enqueue by evaluating the rbtree insertion result.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 kernel/hrtimer.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Index: linux-2.6.22-rc4-mm/kernel/hrtimer.c
===================================================================
--- linux-2.6.22-rc4-mm.orig/kernel/hrtimer.c	2007-06-10 10:44:39.000000000 +0200
+++ linux-2.6.22-rc4-mm/kernel/hrtimer.c	2007-06-10 10:44:39.000000000 +0200
@@ -686,6 +686,7 @@ static void enqueue_hrtimer(struct hrtim
 	struct rb_node **link = &base->active.rb_node;
 	struct rb_node *parent = NULL;
 	struct hrtimer *entry;
+	int leftmost = 1;
 
 	/*
 	 * Find the right place in the rbtree:
@@ -697,18 +698,19 @@ static void enqueue_hrtimer(struct hrtim
 		 * We dont care about collisions. Nodes with
 		 * the same expiry time stay together.
 		 */
-		if (timer->expires.tv64 < entry->expires.tv64)
+		if (timer->expires.tv64 < entry->expires.tv64) {
 			link = &(*link)->rb_left;
-		else
+		} else {
 			link = &(*link)->rb_right;
+			leftmost = 0;
+		}
 	}
 
 	/*
 	 * Insert the timer to the rbtree and check whether it
 	 * replaces the first pending timer
 	 */
-	if (!base->first || timer->expires.tv64 <
-	    rb_entry(base->first, struct hrtimer, node)->expires.tv64) {
+	if (leftmost) {
 		/*
 		 * Reprogram the clock event device. When the timer is already
 		 * expired hrtimer_enqueue_reprogram has either called the

-- 


  parent reply	other threads:[~2007-06-10  9:34 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-10  9:43 [patch-mm 00/23] High resolution timer updates and x86_64 support Thomas Gleixner
2007-06-10  9:43 ` [patch-mm 01/23] NOHZ: Fix ARM,SH,SPARC64 idle nohz handling Thomas Gleixner
2007-06-11  0:26   ` Paul Mundt
2007-06-11  5:20     ` Thomas Gleixner
2007-06-11  5:32       ` Paul Mundt
2007-06-10  9:44 ` [patch-mm 02/23] ACPI: Move timer broadcast and pmtimer access before C3 arbiter shutdown Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 03/23] Clockevents remove prototypes of removed functions Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 04/23] Timekeeping: Fixup shadow variable argument Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 05/23] timer.c cleanup recently introduced whitespace damage Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 06/23] clockevents: Fix resume logic Thomas Gleixner
2007-06-10  9:43   ` Nigel Cunningham
2007-06-10  9:51     ` Thomas Gleixner
2007-06-10 10:19   ` Rafael J. Wysocki
2007-06-10 10:30     ` Thomas Gleixner
2007-06-10 10:58       ` Rafael J. Wysocki
2007-06-10 13:17         ` Thomas Gleixner
2007-06-10 16:34           ` Rafael J. Wysocki
2007-06-10 18:45             ` Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 07/23] Tick management: spread timer interrupt Thomas Gleixner
2007-06-10 14:16   ` Andreas Mohr
2007-06-10 14:31     ` Thomas Gleixner
2007-06-10 14:35       ` Andreas Mohr
2007-06-10  9:44 ` [patch-mm 08/23] i386: PIT stop only, when in periodic or oneshot mode Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 09/23] clockevents: Fix device replacement Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 10/23] highres: Improve debug output Thomas Gleixner
2007-06-10  9:44 ` Thomas Gleixner [this message]
2007-06-10  9:44 ` [patch-mm 12/23] pcspkr: use the global PIT lock Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 13/23] i386: hpet assumes boot cpu is 0 Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 14/23] NTP: Move the cmos update code into ntp.c Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 15/23] x86_64: untangle asm/hpet.h from asm/timex.h Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 16/23] x86_64: Use generic cmos update Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 17/23] i386: move setup_pit_timer to the correct header file Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 18/23] x86-64: remove dead code and other janitor work in tsc.c Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 19/23] x86_64: Convert to cleckevents Thomas Gleixner
2007-06-11  8:47   ` Sébastien Dugué
2007-06-11  8:57     ` Thomas Gleixner
2007-06-11 19:12     ` [patch-mm 19a/23] x86_64: hpet restore vread Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 20/23] x86_64: restore restore nohpet cmdline Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 21/23] x86-64 block irq balancing for timer Thomas Gleixner
2007-06-10 16:29   ` Arjan van de Ven
2007-06-11 19:24     ` Pallipadi, Venkatesh
2007-06-10  9:44 ` [patch-mm 22/23] x86_64: prep idle loop for dynticks Thomas Gleixner
2007-06-10  9:44 ` [patch-mm 23/23] x86_64: enable high resolution timers and dynticks Thomas Gleixner
2007-06-10 22:46 ` [patch-mm 00/23] High resolution timer updates and x86_64 support Mark Lord
2007-06-11  5:19   ` Thomas Gleixner
2007-06-11 22:43     ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070610092446.773377570@inhelltoy.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=chrisw@sous-sol.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®