From: Chris Wright <chrisw@sous-sol.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Greg KH <greg@kroah.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andi Kleen <ak@suse.de>, Ralf Baechle <ralf@linux-mips.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ingo Molnar <mingo@elte.hu>, Stable Team <stable@kernel.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [stable] [PATCH] INPUT: Sanitize PIT locking in pcspkr
Date: Mon, 11 Jun 2007 17:27:47 -0700 [thread overview]
Message-ID: <20070612002747.GJ3723@sequoia.sous-sol.org> (raw)
In-Reply-To: <1179408962.3764.72.camel@chaos>
* Thomas Gleixner (tglx@linutronix.de) wrote:
> The PC-speaker code has a quite creative method to serialize access to
> the PIT: It uses a local lock.
>
> On i386 and x86_64 the access to the PIT is serialized by a lock in the
> architecture code. The separate locking in the PC-speaker code ignores
> the global lock and creates a nasty race between the PC-speaker and the
> PIT clock source / events code on SMP machines.
>
> Use the global i8253_lock instead of the local i8253_beep_lock, when
> compiled for i386/x86_64.
Seems this one got lost?
thanks,
-chris
next prev parent reply other threads:[~2007-06-12 0:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 13:36 Thomas Gleixner
2007-05-17 14:15 ` Dmitry Torokhov
2007-05-17 14:35 ` Thomas Gleixner
2007-05-17 14:36 ` Dmitry Torokhov
2007-05-17 14:49 ` Thomas Gleixner
2007-05-18 4:27 ` Andi Kleen
2007-05-18 6:26 ` Dmitry Torokhov
2007-06-12 0:27 ` Chris Wright [this message]
2007-06-12 5:50 ` [stable] " Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070612002747.GJ3723@sequoia.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=dmitry.torokhov@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome