From: Adrian Bunk <bunk@stusta.de>
To: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: fix placement of inline keyword.
Date: Wed, 13 Jun 2007 01:38:42 +0200 [thread overview]
Message-ID: <20070612233842.GJ3588@stusta.de> (raw)
In-Reply-To: <20070612233035.GA24146@redhat.com>
On Tue, Jun 12, 2007 at 07:30:35PM -0400, Dave Jones wrote:
> gcc gets whiney about the placement of 'inline' at some warning levels.
>...
Since most of them are in C files, can you remove these when you are at it?
> --- linux-2.6.20.noarch/arch/ia64/sn/pci/pcibr/pcibr_ate.c~ 2007-04-04 19:34:50.000000000 -0400
> +++ linux-2.6.20.noarch/arch/ia64/sn/pci/pcibr/pcibr_ate.c 2007-04-04 19:34:56.000000000 -0400
> @@ -138,7 +138,7 @@ static inline u64 __iomem *pcibr_ate_add
> /*
> * Update the ate.
> */
> -void inline
> +inline void
> ate_write(struct pcibus_info *pcibus_info, int ate_index, int count,
> volatile u64 ate)
> {
>...
And some are even non-static inline functions...
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-06-12 23:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 23:30 Dave Jones
2007-06-12 23:38 ` Adrian Bunk [this message]
2007-06-12 23:42 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070612233842.GJ3588@stusta.de \
--to=bunk@stusta.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome