mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] make hdrscheck.sh force __asm__ in exported headers
Date: Mon, 18 Jun 2007 04:07:28 -0400	[thread overview]
Message-ID: <200706180407.29352.vapier@gentoo.org> (raw)
In-Reply-To: <20070618075410.GC21222@uranus.ravnborg.org>

[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]

On Monday 18 June 2007, Sam Ravnborg wrote:
> On Sun, Jun 17, 2007 at 06:54:24PM -0400, Mike Frysinger wrote:
> > This updates scripts/hdrschecks.sh by grepping for asm() constructs and
> > rejecting them in favor of __asm__() in exported headers.
>
> I have a new version of hdrcheck in works written in perl
> and a bit faster too.
> I hope to finish it off this weekend and sent it for review.
> Could I ask you to pick it up and add the below test to that version
> when it hits mainline - assuming that the other patches has hit mainline
> too. I do not want this check before we are clean so we basically use it to
> check that noone introduce a bug.

that's fine ... one of the other things i wanted to add were checks to make 
sure the exported headers did not contain [us](8|16|32|64) references, but 
there's headers which refer to these in comment blocks or use them as members 
of structs (like the netfilter code) so i couldnt add that check without 
passing things through the preprocessor ... perhaps your perl code would 
better accommodate this, perhaps not ;)
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

      reply	other threads:[~2007-06-18  8:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-17 22:54 Mike Frysinger
2007-06-18  5:11 ` Andrew Morton
2007-06-18  5:17   ` Mike Frysinger
2007-06-18  5:34     ` Andrew Morton
2007-06-18  5:53       ` Mike Frysinger
2007-06-18  5:54       ` Mike Frysinger
2007-06-18  6:28       ` Mike Frysinger
2007-06-18  7:54 ` Sam Ravnborg
2007-06-18  8:07   ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706180407.29352.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®