Re: [PATCH] Quota netlink interface

[Randy Dunlap <randy.dunlap@oracle.com>]

On Mon, 18 Jun 2007 14:14:55 +0200 Jan Kara wrote:

>   Hello,
> 
>   I've written a patch implementing quota netlink interface. Whenever some
> event happens (like user exceeding softlimit), a message is sent to
> userpace. Then, in userspace we can decide what to do with the message -
> print it to console, show a dialog or whatever... I've also written a new
> daemon that listens to netlink and sends the received message to DBus and/or
> to the console the user has last written to.
>   If somebody is interested in trying it out, he can checkout latest
> quota-tools CVS and I can provide him with the modified libnl providing
> better support for generic netlink handling.


+config QUOTA_NETLINK_INTERFACE
+	bool "Report quota messages through netlink interface"
+	depends on QUOTA
+	select NET
+	help
+	  If you say Y here, quota warnings (about exceeding softlimit, reaching
+	  hardlimit, etc.) will be reported through netlink interface. If unsure,
+	  say Y.


Using "select" is either evil or OK, but only OK for "library-type" code.
It should never be used to pull in a complete subsystem like NET does
(even though SCSI_NETLINK does this same thing, sadly).


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***