From: Christoph Hellwig <hch@infradead.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
ak@suse.de
Subject: Re: [patch] use __asm__ and __volatile__ in asm-x86_64/msr.h
Date: Mon, 18 Jun 2007 19:36:51 +0100 [thread overview]
Message-ID: <20070618183651.GB17112@infradead.org> (raw)
In-Reply-To: <200706181002.21978.vapier@gentoo.org>
On Mon, Jun 18, 2007 at 10:02:21AM -0400, Mike Frysinger wrote:
> > This is wrong for two reasons:
> >
> > - MSRs are not accessible in user space.
> > - .section .fixup is not applicable to user space.
> >
> > Anything MSR-related should be protected by __KERNEL__ instead.
> >
> > This NAK doesn't apply to rdtsc* and rdpmc* changes, however, as those
> > instructions are legitimate in userspace.
>
> then someone needs to audit msr.h for this because currently it lacks
> __KERNEL__ of any kind yet is exported completely to userspace ... i dont
> know anything about this instructions so that someone != me
>
> this is similar to what i heard last time i tried to fixup msr.h for
> userspace, but the file still hasnt been updated ...
asm-i386/msr.h should not be exported to userspace at all, it contains
nothing but kernel-internal helpers.
next prev parent reply other threads:[~2007-06-18 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 6:09 Mike Frysinger
2007-06-18 7:35 ` H. Peter Anvin
2007-06-18 14:02 ` Mike Frysinger
2007-06-18 18:36 ` Christoph Hellwig [this message]
2007-06-18 18:53 ` Andi Kleen
2007-06-20 15:46 ` H. Peter Anvin
2007-07-23 0:45 ` Mike Frysinger
2007-07-23 1:18 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070618183651.GB17112@infradead.org \
--to=hch@infradead.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®