From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765564AbXFRSn4 (ORCPT ); Mon, 18 Jun 2007 14:43:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764599AbXFRSnr (ORCPT ); Mon, 18 Jun 2007 14:43:47 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:58969 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761290AbXFRSnp (ORCPT ); Mon, 18 Jun 2007 14:43:45 -0400 Date: Mon, 18 Jun 2007 19:43:43 +0100 From: Christoph Hellwig To: "Robert P. J. Day" Cc: Linux Kernel Mailing List , Andrew Morton , xfs-masters@oss.sgi.com Subject: Re: [PATCH] XFS: Replace remaining memclear_highpage_flush() with zero_user_page(). Message-ID: <20070618184343.GB17479@infradead.org> Mail-Followup-To: Christoph Hellwig , "Robert P. J. Day" , Linux Kernel Mailing List , Andrew Morton , xfs-masters@oss.sgi.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 18, 2007 at 11:59:30AM -0400, Robert P. J. Day wrote: > > Signed-off-by: Robert P. J. Day > > --- > > this appears to be the final occurrence of that deprecated call in > the entire tree which suggests that, if you're not concerned about > out-of-tree modules, that definition could also be removed from > include/linux/highmem.h: > > static inline void __deprecated memclear_highpage_flush(struct page *page, > unsigned int offset, unsigned int size) > { > zero_user_page(page, offset, size, KM_USER0); > } Andrew, please send this and the memclear_highpage_flush removal to Linus for 2.6.22-rc. The warning is really highly annoying and utterly pointless.