mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: "Andreas Herrmann" <andreas.herrmann3@amd.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 5/12] acpi: fix compile error with ACPI && !ACPI_SYSTEM
Date: Tue, 19 Jun 2007 23:36:01 -0400	[thread overview]
Message-ID: <200706192336.02078.lenb@kernel.org> (raw)
In-Reply-To: <20070619224958.GG5193@alberich.amd.com>

On Tuesday 19 June 2007 18:49, Andreas Herrmann wrote:
> Fix build error if ACPI && !ACPI_SYSTEM as
> bus.c depended on event.c

How were you able to get ACPI & !ACPI_SYSTEM to survive "make oldconfig"?

-Len

> Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> ---
>  drivers/acpi/bus.c   |    2 +-
>  drivers/acpi/event.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index e5084ec..b4a9ea5 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -281,7 +281,7 @@ static DEFINE_SPINLOCK(acpi_bus_event_lock);
>  LIST_HEAD(acpi_bus_event_list);
>  DECLARE_WAIT_QUEUE_HEAD(acpi_bus_event_queue);
>  
> -extern int event_is_open;
> +int event_is_open = 0;
>  
>  int acpi_bus_generate_event(struct acpi_device *device, u8 type, int data)
>  {
> diff --git a/drivers/acpi/event.c b/drivers/acpi/event.c
> index 3b23562..15886c1 100644
> --- a/drivers/acpi/event.c
> +++ b/drivers/acpi/event.c
> @@ -17,7 +17,7 @@ ACPI_MODULE_NAME("event");
>  
>  /* Global vars for handling event proc entry */
>  static DEFINE_SPINLOCK(acpi_system_event_lock);
> -int event_is_open = 0;
> +extern int event_is_open;
>  extern struct list_head acpi_bus_event_list;
>  extern wait_queue_head_t acpi_bus_event_queue;
>  

      reply	other threads:[~2007-06-20  3:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19 22:49 Andreas Herrmann
2007-06-20  3:36 ` Len Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706192336.02078.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=andreas.herrmann3@amd.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome