From: Stephane Eranian <eranian@hpl.hp.com>
To: David Rientjes <rientjes@google.com>
Cc: Robert Richter <robert.richter@amd.com>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2/8] 2.6.22-rc3 perfmon2 : Debug messages added
Date: Wed, 20 Jun 2007 13:39:44 -0700 [thread overview]
Message-ID: <20070620203944.GB26200@frankl.hpl.hp.com> (raw)
In-Reply-To: <alpine.DEB.0.99.0706201326310.6935@chino.kir.corp.google.com>
On Wed, Jun 20, 2007 at 01:28:50PM -0700, David Rientjes wrote:
> On Wed, 20 Jun 2007, Stephane Eranian wrote:
>
> > > After commenting on your first set of patches, I've been using it a little
> > > more. In my use, these debugging messages weren't very helpful because
> > > "pfm_file_ops" can indicate pfm_mmap, pfm_read, pfm_poll, etc. Could
> > > these be changed to be more specific based on the function they're in?
> > >
> > the PFM_DBG() macro adds the CPU, function name and line number to the
> > printed string.
> >
>
> That's not the case in what I currently have in my tree, I'll go back and
> see what I'm missing.
Bizarre. Becuase if you've disabled CONFIG_PERFMON_DEBUG, then all the PFM_DBG()
are removed.
>
> What's the current status of the perfmon2 patchset that Robert's work is
> based on?
Well, I have been hacking on it a lot especially to allow Oprofile and
perfmon2 to co-exist (mutual-exclusion). I am hoping to release something
before I fly to OLS next week. I have started integrating Robert's patches.
I also have to integrate IBM's Cell support patch.
--
-Stephane
next prev parent reply other threads:[~2007-06-20 20:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070620182126.248753000@amd.com>
2007-06-20 18:41 ` [patch 1/8] 2.6.22-rc3 perfmon2 : Barcelona CPU detection Robert Richter
2007-06-20 19:45 ` David Rientjes
2007-06-21 10:29 ` Robert Richter
2007-06-20 18:41 ` [patch 2/8] 2.6.22-rc3 perfmon2 : Debug messages added Robert Richter
2007-06-20 19:49 ` David Rientjes
2007-06-20 20:22 ` Stephane Eranian
2007-06-20 20:28 ` David Rientjes
2007-06-20 20:39 ` Stephane Eranian [this message]
2007-06-20 20:45 ` David Rientjes
2007-06-20 20:54 ` Stephane Eranian
2007-06-21 10:30 ` Robert Richter
2007-06-21 14:00 ` Robert Richter
2007-06-21 12:32 ` Andi Kleen
2007-06-20 18:41 ` [patch 3/8] 2.6.22-rc3 perfmon2 : Minor changes Robert Richter
2007-06-20 18:41 ` [patch 4/8] 2.6.22-rc3 perfmon2 : Rearrangement of AMD64 MSR definitions, 2nd try Robert Richter
2007-06-20 18:41 ` [patch 5/8] 2.6.22-rc3 perfmon2 : Initial AMD64 PMU configuration Robert Richter
2007-06-20 18:41 ` [patch 6/8] 2.6.22-rc3 perfmon2 : IBS implementation for AMD64 Robert Richter
2007-06-20 20:43 ` Stephane Eranian
2007-06-20 18:41 ` [patch 7/8] 2.6.22-rc3 perfmon2 : Renaming *_k8_* symbols to *_amd64_* Robert Richter
2007-06-20 19:43 ` David Rientjes
2007-06-21 14:00 ` Robert Richter
2007-06-20 18:42 ` [patch 8/8] 2.6.22-rc3 perfmon2 : Renaming of module perfmon_k8 to perfmon_amd64 Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070620203944.GB26200@frankl.hpl.hp.com \
--to=eranian@hpl.hp.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®