mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: oops with USB serial irda adapter
Date: Thu, 21 Jun 2007 00:17:50 +0100	[thread overview]
Message-ID: <20070621001750.283f48ac@the-village.bc.nu> (raw)
In-Reply-To: <4679A74F.4010901@redhat.com>

On Wed, 20 Jun 2007 18:16:47 -0400
Chuck Ebbert <cebbert@redhat.com> wrote:

> [https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241598]
> 
> Oops happens here in kernel 2.6.20.11:
> drivers/usb/serial/ir-usb.c, line 557:
> 
>                 /* Notify the tty driver that the termios have changed. */
>                 port->tty->ldisc.set_termios(port->tty, NULL);
> 
> (ldisc.set_termios is NULL)

Yeah the driver is full of bugs - its also broken for the way its
set_termios tries to play 'guess it the properties have changed' and gets
speed checks wrong, how it snoops the baud bits and some other stuff it
does.

If you make it look like a real serial driver it ought to work fine. If
you've got hardware I can send you test patches ?

  reply	other threads:[~2007-06-20 23:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-20 22:16 Chuck Ebbert
2007-06-20 23:17 ` Alan Cox [this message]
2007-06-21 15:16   ` Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070621001750.283f48ac@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=cebbert@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®