mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 6/12] acpi: fix compile warnings
Date: Fri, 22 Jun 2007 13:34:37 +0200	[thread overview]
Message-ID: <20070622113437.GM23017@stusta.de> (raw)
In-Reply-To: <20070619225011.GH5193@alberich.amd.com>

On Wed, Jun 20, 2007 at 12:50:11AM +0200, Andreas Herrmann wrote:
> Fix compile warnings:
> 
>  drivers/acpi/bus.c: In function 'acpi_bus_get_power':
>  drivers/acpi/bus.c:162: warning: implicit declaration of function 'acpi_power_get_inferred_state'
>  drivers/acpi/bus.c: In function 'acpi_bus_set_power':
>  drivers/acpi/bus.c:232: warning: implicit declaration of function 'acpi_power_transition'
> 
> Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> ---
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index b4a9ea5..e01dca1 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -43,6 +43,8 @@ ACPI_MODULE_NAME("bus");
>  #ifdef	CONFIG_X86
>  extern void __init acpi_pic_sci_set_trigger(unsigned int irq, u16 trigger);
>  #endif
> +extern int acpi_power_get_inferred_state(struct acpi_device *);
> +extern int acpi_power_transition(struct acpi_device *, int);
>...

NAK, they belong into a header file.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      reply	other threads:[~2007-06-22 11:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19 22:50 Andreas Herrmann
2007-06-22 11:34 ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070622113437.GM23017@stusta.de \
    --to=bunk@stusta.de \
    --cc=andreas.herrmann3@amd.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®