From: Andrew Morton <akpm@linux-foundation.org>
To: Wang Zhenyu <zhenyu.z.wang@intel.com>
Cc: davej@redhat.com, carlo@alinoe.com, linux-kernel@vger.kernel.org,
eric@anholt.net
Subject: Re: [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port
Date: Sat, 23 Jun 2007 09:52:03 -0700 [thread overview]
Message-ID: <20070623095203.66bb8572.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070621054318.GA31381@zhen-devel.sh.intel.com>
> On Thu, 21 Jun 2007 13:43:18 +0800 Wang Zhenyu <zhenyu.z.wang@intel.com> wrote:
> Thanks Carlo to report this problem. The following patch should fix
> his and potential issue.
>
> [AGPGART] intel_agp: don't load if no IGD detected and no AGP port
>
> After i915 chip, GMCH has no AGP port. Origin bridge driver in device
> table will try to access illegal regs like APBASE, APSIZE, etc. This
> may cause problem.
>
> So mark them as NULL in the table, we won't load if no IGD got detect
> and bridge has no AGP port.
Looking at the above, I have no way of telling what the actual bug is, nor
have I any way of telling what the consequences would be of not having this
patch in 2.6.22. Nor can I tell whether we want it in 2.6.21.x.
I probably _could_ work this out, and kinda did with a bit of list-trolling
(verdict: needed in 2.6.22) but please, take care to describe the
importance of a patch in the changelog?
Thanks.
next prev parent reply other threads:[~2007-06-23 16:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-17 18:22 2.6.22-rc5 regression Carlo Wood
2007-06-17 19:58 ` Carlo Wood
2007-06-17 21:49 ` Carlo Wood
2007-06-17 23:18 ` Paul Mundt
2007-06-18 0:10 ` Carlo Wood
2007-06-18 0:25 ` Paul Mundt
2007-06-18 7:01 ` Sean
2007-06-18 17:01 ` Linus Torvalds
2007-06-18 18:12 ` Carlo Wood
2007-06-18 18:15 ` Carlo Wood
2007-06-18 18:35 ` Linus Torvalds
2007-06-18 19:54 ` Carlo Wood
2007-06-18 20:42 ` Linus Torvalds
2007-06-18 22:30 ` Daniel Barkalow
2007-06-18 22:50 ` Carlo Wood
2007-06-18 22:57 ` Linus Torvalds
2007-06-19 23:37 ` Carlo Wood
2007-06-19 23:44 ` Dave Jones
2007-06-20 0:09 ` Linus Torvalds
2007-06-20 13:11 ` Carlo Wood
2007-06-20 13:31 ` Carlo Wood
2007-06-20 1:15 ` Wang Zhenyu
2007-06-20 1:42 ` Wang Zhenyu
2007-06-20 14:02 ` Carlo Wood
2007-06-20 15:46 ` Wang Zhenyu
2007-06-21 5:43 ` [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port Wang Zhenyu
2007-06-21 16:10 ` Carlo Wood
2007-06-22 0:55 ` Wang Zhenyu
2007-06-23 16:52 ` Andrew Morton [this message]
2007-06-23 18:42 ` Dave Jones
2007-06-23 18:50 ` Andrew Morton
2007-06-23 19:06 ` Dave Jones
2007-06-25 1:01 ` Wang Zhenyu
2007-06-20 13:22 ` 2.6.22-rc5 regression Carlo Wood
2007-06-20 13:58 ` Carlo Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070623095203.66bb8572.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=carlo@alinoe.com \
--cc=davej@redhat.com \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=zhenyu.z.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome