From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: gregkh@suse.de, linux-pci@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org, grundler@parisc-linux.org,
davem@davemloft.net, davej@redhat.com
Subject: Re: [PATCH 2/2] [RESEND] PCI: Change all drivers to use pci_device->revision
Date: Mon, 25 Jun 2007 10:04:47 +0100 [thread overview]
Message-ID: <20070625100447.1b3ae35e@the-village.bc.nu> (raw)
In-Reply-To: <20070625031929.4711.79012.stgit@localhost.localdomain>
On Sun, 24 Jun 2007 20:19:29 -0700
Auke Kok <auke-jan.h.kok@intel.com> wrote:
> Instead of all drivers reading pci config space to get the revision
> ID, they can now use the pci_device->revision member.
>
> This exposes some issues where drivers where reading a word or a dword
> for the revision number, and adding useless error-handling around the
> read. Some drivers even just read it for no purpose of all.
>
> In devices where the revision ID is being copied over and used in what
> appears to be the equivalent of hotpath, I have left the copy code
> and the cached copy as not to influence the driver's performance.
>
> Compile tested with make all{yes,mod}config on x86_64 and i386.
Ack the drivers/ata part but please split this up per subsystem and send
the chunks to the subsystem maintainers.
Alan
next prev parent reply other threads:[~2007-06-25 9:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 3:19 [PATCH 1/2] [RESEND] PCI: read revision ID by default Auke Kok
2007-06-25 3:19 ` [PATCH 2/2] [RESEND] PCI: Change all drivers to use pci_device->revision Auke Kok
2007-06-25 9:04 ` Alan Cox [this message]
2007-06-25 7:20 ` [PATCH 1/2] [RESEND] PCI: read revision ID by default Greg KH
2007-06-25 9:01 ` Alan Cox
2007-06-25 18:49 ` Kok, Auke
2007-06-25 19:48 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070625100447.1b3ae35e@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=auke-jan.h.kok@intel.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=grundler@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®