mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: dougthompson@xmission.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] fs-sysfs bugfix of sysfs_hash_and_remove dereferencing before checking for NULL
Date: Mon, 25 Jun 2007 14:25:43 -0700	[thread overview]
Message-ID: <20070625212543.GB13415@kroah.com> (raw)
In-Reply-To: <887490.81074.qm@web50106.mail.re2.yahoo.com>

On Fri, Jun 22, 2007 at 10:13:24AM -0700, Doug Thompson wrote:
> From:	Douglas Thompson <dougthompson@xmission.com>
> 
> In tracking down one of my bugs in using sysfs, I found the kernel doing a NULL de-reference
> in function fs/sysfs/inode.c:sysfs_hash_and_remove(), when I (incorrectly) passed
> in a dentry value of NULL.
> 
> The check for NULL should occur BEFORE the dereference of 'dir'. 
> This patch modifies the sequence and does the check FIRST
> 
> 
> Signed-off-by:	Douglas Thompson <dougthompson@xmission.com>
> ---
> 
> Index: linux-2.6.22-rc4-mm2/fs/sysfs/inode.c

There's been a lot of churn and change in this area and this patch
doens't apply anymore.  Can you try respinning it against the next -mm
release and resending it if it is still needed?

thanks,

greg k-h


      reply	other threads:[~2007-06-25 21:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-22 17:13 Doug Thompson
2007-06-25 21:25 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070625212543.GB13415@kroah.com \
    --to=greg@kroah.com \
    --cc=dougthompson@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®