From: Randy Dunlap <randy.dunlap@oracle.com>
To: Arne Georg Gleditsch <argggh@dolphinics.no>
Cc: Oleg Verych <olecom@flower.upol.cz>, Andi Kleen <ak@suse.de>,
lkml <linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>
Subject: Re: NAK (bashizm in the /bin/sh script): [PATCH v3] doc/oops-tracing: add Code: decode info
Date: Tue, 26 Jun 2007 10:19:58 -0700 [thread overview]
Message-ID: <20070626101958.1cf6c6ae.randy.dunlap@oracle.com> (raw)
In-Reply-To: <87645bhtvw.fsf@pelargir.dolphinics.no>
On Tue, 26 Jun 2007 12:50:27 +0200 Arne Georg Gleditsch wrote:
> Randy Dunlap <randy.dunlap@oracle.com> writes:
> > OTOH, you also didn't supply a patch. If you do this, I'll be
> > glad to consider it. If I can read it, that is.
>
> I like bash as much as the next guy, but (to my surprise) /bin/sh on
> my current workstation is actually dash. How about just replacing the
> substring-interpolations with:
>
> if [ $marker -ne 0 ]; then
> beforemark=`echo "$code" | cut -c-$((marker - 1))`
> [..]
> # and fix code at-and-after marker
> code=`echo "$code" | cut -c$marker-`
> fi
>
> and be done with it?
Are these 2 line changes all that is needed?
I sort of expected expressions like $((a + 2)) to need change also...
maybe not for dash, but for sh?
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-06-26 17:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 5:51 [PATCH] " Randy Dunlap
2007-06-22 14:26 ` Andi Kleen
2007-06-22 16:44 ` [PATCH v2] " Randy Dunlap
2007-06-22 17:23 ` Andi Kleen
2007-06-22 18:25 ` Randy Dunlap
2007-06-22 21:29 ` Andi Kleen
2007-06-22 20:28 ` [PATCH v3] " Randy Dunlap
2007-06-23 8:34 ` NAK (bashizm in the /bin/sh script): " Oleg Verych
2007-06-23 11:00 ` Andi Kleen
2007-06-23 11:09 ` Arkadiusz Miskiewicz
2007-06-23 13:17 ` Andi Kleen
2007-06-23 13:26 ` Willy Tarreau
2007-06-23 13:51 ` [OT]Re: " Oleg Verych
2007-06-23 13:47 ` Björn Steinbrink
2007-06-23 14:24 ` Arkadiusz Miskiewicz
2007-06-23 14:32 ` Alan Cox
2007-06-23 14:34 ` Andi Kleen
2007-06-23 14:48 ` Alan Cox
2007-06-23 15:35 ` Segher Boessenkool
2007-06-23 14:38 ` Sean
2007-06-23 15:23 ` Oleg Verych
2007-06-23 17:43 ` Randy Dunlap
2007-06-23 17:56 ` Andrew Morton
2007-06-23 20:54 ` Adrian Bunk
2007-06-23 21:04 ` Randy Dunlap
2007-06-23 20:24 ` Matthieu CASTET
2007-06-26 10:16 ` DervishD
2007-06-26 10:24 ` Jan-Benedict Glaw
2007-06-26 15:33 ` DervishD
2007-06-26 16:04 ` Randy Dunlap
2007-06-26 17:03 ` DervishD
2007-06-26 10:50 ` Arne Georg Gleditsch
2007-06-26 15:36 ` DervishD
2007-06-26 17:19 ` Randy Dunlap [this message]
2007-06-26 17:25 ` Julio M. Merino Vidal
2007-06-26 17:56 ` Randy Dunlap
2007-06-28 7:58 ` Arne Georg Gleditsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070626101958.1cf6c6ae.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=argggh@dolphinics.no \
--cc=linux-kernel@vger.kernel.org \
--cc=olecom@flower.upol.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®