From: Sam Ravnborg <sam@ravnborg.org>
To: Trilok Soni <soni.trilok@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com,
akpm@linux-foundation.org, Tony Lindgren <tony@atomide.com>,
imre.deak@solidboot.com, juha.yrjola@solidboot.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/17] OMAP: Add TI OMAP1610 accelerator entry.
Date: Tue, 26 Jun 2007 18:52:05 +0200 [thread overview]
Message-ID: <20070626165205.GB22389@uranus.ravnborg.org> (raw)
In-Reply-To: <5d5443650706260534k5d6aca34k9f574b6ffddf85b2@mail.gmail.com>
Your patch ordering is bad.
Patch 1 uses the symbol: FB_ACCEL_OMAP1610
but it is defined by patch 2.
Please reorder patches so the module compiles for each
and every patch being applied.
In this way you do not break git bisect for example.
Sam
next prev parent reply other threads:[~2007-06-26 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 12:34 Trilok Soni
2007-06-26 16:52 ` Sam Ravnborg [this message]
2007-06-27 11:30 ` Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070626165205.GB22389@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=imre.deak@solidboot.com \
--cc=juha.yrjola@solidboot.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=soni.trilok@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®