mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steve Wise <swise@opengridcomputing.com>
To: rdreier@cisco.com
Cc: general@lists.openfabrics.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, divy@chelsio.com
Subject: [PATCH 6/6] iw_cxgb3: Don't abort after failures sending the mpa reply.
Date: Wed, 27 Jun 2007 10:51:50 -0500	[thread overview]
Message-ID: <20070627155150.24944.36124.stgit@dell3.ogc.int> (raw)
In-Reply-To: <20070627155119.24944.44172.stgit@dell3.ogc.int>


iw_cxgb3: Don't abort after failures sending the mpa reply.

This bug results in an abort request being sent down _after_ the tid
has been released.  If the tid happens to have been reused, then the
subsequent generation of the tid gets incorrectly aborted.

The thread running iwch_accecpt_cr() must not abort a connection if an
error is returned after being awakened.  If any errors did occur while
iwch_accept_cr() is blocked, then the connection has already been aborted
on the thread processing the error.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---

 drivers/infiniband/hw/cxgb3/iwch_cm.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
index 228721f..3b41dc0 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
@@ -1781,7 +1781,6 @@ err:
 	ep->com.cm_id = NULL;
 	ep->com.qp = NULL;
 	cm_id->rem_ref(cm_id);
-	abort_connection(ep, NULL, GFP_KERNEL);
 	put_ep(&ep->com);
 	return err;
 }

  parent reply	other threads:[~2007-06-27 15:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-27 15:51 [PATCH 0/6] iw_cxgb3: Bug Fixes for 2.6.23 Steve Wise
2007-06-27 15:51 ` [PATCH 1/6] iw_cxgb3: Streaming -> RDMA mode transition fixes Steve Wise
2007-06-27 15:51 ` [PATCH 2/6] iw_cxgb3: TERMINATE WRs can hang the tx ofld queue Steve Wise
2007-06-27 15:51 ` [PATCH 3/6] iw_cxgb3: Don't count neg_adv abort_req_rss messages as real aborts Steve Wise
2007-06-27 15:51 ` [PATCH 4/6] iw_cxgb3: ctrl-qp init/clear shouldn't set the gen bit Steve Wise
2007-06-27 15:51 ` [PATCH 5/6] iw_cxgb3: Don't post TID_RELEASE message Steve Wise
2007-06-27 15:51 ` Steve Wise [this message]
2007-06-27 19:14 ` [PATCH 0/6] iw_cxgb3: Bug Fixes for 2.6.23 Roland Dreier
2007-06-27 19:31   ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070627155150.24944.36124.stgit@dell3.ogc.int \
    --to=swise@opengridcomputing.com \
    --cc=divy@chelsio.com \
    --cc=general@lists.openfabrics.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®