From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755457AbXGBQxz (ORCPT ); Mon, 2 Jul 2007 12:53:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752862AbXGBQxr (ORCPT ); Mon, 2 Jul 2007 12:53:47 -0400 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:44209 "EHLO the-village.bc.nu" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752238AbXGBQxq (ORCPT ); Mon, 2 Jul 2007 12:53:46 -0400 Date: Mon, 2 Jul 2007 17:59:26 +0100 From: Alan Cox To: Linus Torvalds Cc: Andi Kleen , Stephen Hemminger , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: blink driver power saving Message-ID: <20070702175926.30b2f718@the-village.bc.nu> In-Reply-To: References: <20070701125035.3f54d8b0@oldman> <200707012329.52918.ak@suse.de> <200707020159.51200.ak@suse.de> X-Mailer: Claws Mail 2.9.1 (GTK+ 2.10.8; i386-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > > Anyways, Stephen's patch just doesn't make sense: > > he clearly didn't understand the code at all. Before you > > apply it and cripple it better drop the driver completely. > > I think I will have to. Make it depend on the kernel debug options and if you are really paranoid also add a module option to enable it at boot time. The module option works pretty well and various old and new IDE drivers do it to stop make allyesconfig accidents