From: David Miller <davem@davemloft.net>
To: dwmw2@infradead.org
Cc: mark@mtfhpc.demon.co.uk, linux-mm@kvack.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org, clameter@engr.sgi.com,
wli@holomorphy.com
Subject: Re: [PATCH] Re: Sparc32: random invalid instruction occourances on sparc32 (sun4c)
Date: Tue, 03 Jul 2007 14:41:12 -0700 (PDT) [thread overview]
Message-ID: <20070703.144112.24611353.davem@davemloft.net> (raw)
In-Reply-To: <1183490778.29081.35.camel@shinybook.infradead.org>
From: David Woodhouse <dwmw2@infradead.org>
Date: Tue, 03 Jul 2007 15:26:18 -0400
> On Tue, 2007-07-03 at 19:57 +0100, Mark Fortescue wrote:
> > > Commit b46b8f19c9cd435ecac4d9d12b39d78c137ecd66 partially fixed alignment
> > > issues but does not ensure that all 64bit alignment requirements of sparc32
> > > are met. Tests have shown that the redzone2 word can become misallignd.
>
> Oops, sorry about that. I'm not sure about your patch though -- I think
> I'd prefer to keep the redzone misaligned (and hence _right_ next to the
> real data), and just deal with it.
>
> typedef unsigned long long __aligned__((BYTES_PER_WORD)) redzone_t;
Please don't use get_unaligned() or whatever to fix this, it's
going to generate the byte-at-a-time accesses on sparc64
which doesn't need it since the redzone will be aligned.
next prev parent reply other threads:[~2007-07-03 21:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 16:45 [1/2] 2.6.22-rc7: known regressions Michal Piotrowski
2007-07-03 17:29 ` Sparc32: random invalid instruction occourances on sparc32 (sun4c) Mark Fortescue
2007-07-03 18:57 ` [PATCH] " Mark Fortescue
2007-07-03 19:26 ` David Woodhouse
2007-07-03 21:25 ` Mark Fortescue
2007-07-03 21:56 ` David Woodhouse
2007-07-03 22:47 ` Mark Fortescue
2007-07-03 23:36 ` David Woodhouse
2007-07-04 3:27 ` Mark Fortescue
2007-07-04 3:33 ` David Woodhouse
2007-07-04 10:27 ` Mark Fortescue
2007-07-04 14:46 ` David Woodhouse
2007-07-04 18:38 ` Mark Fortescue
2007-07-03 21:41 ` David Miller [this message]
2007-07-03 22:01 ` David Woodhouse
2007-07-03 17:50 ` [1/2] 2.6.22-rc7: known regressions Bartlomiej Zolnierkiewicz
2007-07-03 23:09 ` David Chinner
2007-07-05 0:20 ` David Woodhouse
2007-07-05 1:26 ` [PATCH 2.6.22 REGRESSION] Fix slab redzone alignment David Woodhouse
2007-07-05 1:42 ` [1/2] 2.6.22-rc7: known regressions David Woodhouse
2007-07-05 16:28 ` Linus Torvalds
2007-07-05 16:43 ` David Woodhouse
2007-07-05 18:46 ` David Woodhouse
2007-07-05 19:31 ` David Woodhouse
2007-07-05 19:51 ` Linus Torvalds
2007-07-05 21:03 ` Dmitry Torokhov
2007-07-06 22:50 ` Jiri Kosina
2007-07-07 0:33 ` Dmitry Torokhov
2007-07-07 1:05 ` Jiri Kosina
2007-07-07 1:28 ` David Woodhouse
2007-07-07 2:25 ` David Woodhouse
2007-07-07 18:28 ` Marcel Holtmann
2007-07-07 18:36 ` Linus Torvalds
2007-07-07 18:58 ` [PATCH] Fix use-after-free oops in Bluetooth HID David Woodhouse
2007-07-07 19:27 ` Linus Torvalds
2007-07-09 2:32 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070703.144112.24611353.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=clameter@engr.sgi.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark@mtfhpc.demon.co.uk \
--cc=sparclinux@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®