From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756785AbXGDWjj (ORCPT ); Wed, 4 Jul 2007 18:39:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751328AbXGDWjb (ORCPT ); Wed, 4 Jul 2007 18:39:31 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:48267 "EHLO amd.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750730AbXGDWja (ORCPT ); Wed, 4 Jul 2007 18:39:30 -0400 Date: Thu, 5 Jul 2007 00:39:22 +0200 From: Pavel Machek To: "Rafael J. Wysocki" Cc: seife@suse.de, nigel@nigel.suspend2.net, linux-kernel@vger.kernel.org, suspend-devel@lists.sourceforge.net Subject: Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND Message-ID: <20070704223921.GA2491@elf.ucw.cz> References: <20070628135108.GA1810@elf.ucw.cz> <200706281734.54642.rjw@sisk.pl> <20070704193313.GF2728@elf.ucw.cz> <200707042344.25207.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200707042344.25207.rjw@sisk.pl> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > > > diff --git a/drivers/char/lp.c b/drivers/char/lp.c > > > > index 62051f8..8267ff8 100644 > > > > --- a/drivers/char/lp.c > > > > +++ b/drivers/char/lp.c > > > > @@ -144,7 +144,7 @@ static unsigned int lp_count = 0; > > > > static struct class *lp_class; > > > > > > > > #ifdef CONFIG_LP_CONSOLE > > > > -static struct parport *console_registered; // initially NULL > > > > +static struct parport *console_registered; > > > > #endif /* CONFIG_LP_CONSOLE */ > > > > > > Could you please avoid fixing things like this, white space etc. in this patch? > > > It would be easier to read ... > > > > Yep, sorry, it should be separate patch. I hope the idea is still > > simple enough. > > Yes, but I'm not sure if netconsole is the only one that we will want to have Well, netconsole is the only one we know of. > disabled. Moreover, what if someone wants to use the netconsole regardless > of the fact that it can crash the box? He'll have to edit the sources at that point. I'd prefer not to have too many "please crash the box" options. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html