From: Andi Kleen <andi@firstfloor.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Andi Kleen <andi@firstfloor.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] Thread Migration Preemption
Date: Fri, 6 Jul 2007 19:11:59 +0200 [thread overview]
Message-ID: <20070706171159.GB8174@one.firstfloor.org> (raw)
In-Reply-To: <20070706144144.GC32754@Krystal>
On Fri, Jul 06, 2007 at 10:41:44AM -0400, Mathieu Desnoyers wrote:
> I haven't thought about making it the default for kernel space
> preemption, but yes, it would make sense.
Now it's too late -- getcpu() has infected the kernel everywhere.
It would have made sense a few years ago.
> ... getcpu()...
Hmm ok, although i suspect it's rare to assume that. But understood
you don't want to audit all getcpu users because of this.
> using a short instead of an int on modern x86 will cause pipeline stalls
> due to partial register use.
Sorry, that's totally bogus. Primarily because the access would be directly
on memory and there is no partial register tracking there.
Besides pipeline stall is not the correct description on what would
happen if you used a register, the worst you get is a single false dependency
but no pipeline flush.
Besides the latest x86 cpus (C2, K8) don't have much trouble with these
false dependencies in general.
> usage, since it is followed by an unsigned long; gcc structure alignment
> will put padding instead of the integer, which does not buy us anything
on i386 unsigned long is 4 bytes.
-Andi
next prev parent reply other threads:[~2007-07-06 17:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 21:51 Mathieu Desnoyers
2007-07-05 22:46 ` Steven Rostedt
2007-07-06 6:12 ` Nick Piggin
2007-07-06 14:34 ` Mathieu Desnoyers
2007-07-06 14:34 ` Steven Rostedt
2007-07-06 15:43 ` Daniel Walker
2007-07-08 9:05 ` Nick Piggin
2007-07-10 23:39 ` Matt Mackall
2007-07-11 0:02 ` Nick Piggin
2007-07-11 0:36 ` Matt Mackall
2007-07-11 0:55 ` Mathieu Desnoyers
2007-07-11 1:15 ` Nick Piggin
2007-07-06 11:59 ` Andi Kleen
2007-07-06 14:41 ` Mathieu Desnoyers
2007-07-06 17:11 ` Andi Kleen [this message]
2007-07-11 4:57 ` Mathieu Desnoyers
2007-07-23 18:33 ` Ingo Molnar
2007-07-06 6:02 Oleg Nesterov
2007-07-06 14:23 ` Mathieu Desnoyers
2007-07-06 14:56 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070706171159.GB8174@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®