From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754839AbXGGXdU (ORCPT ); Sat, 7 Jul 2007 19:33:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752435AbXGGXdJ (ORCPT ); Sat, 7 Jul 2007 19:33:09 -0400 Received: from ug-out-1314.google.com ([66.249.92.172]:31298 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752222AbXGGXdH (ORCPT ); Sat, 7 Jul 2007 19:33:07 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:mime-version:content-type:content-disposition:user-agent; b=qZ1Fa77zp92AlXn1+lKvG5Q5Gdl0Or6khO8m00lwsBBGIC2SXHLPe6O/f9zsJ0FfYMk+LzgRRWEwck17DFUL1O3gT0wzzk8/ERl8l1n4D9Igcnux/5HaY5/2TKvH+oPLYDGqKPVpxJceG5F+fGRV/HG19RYaM+EE2byb0unBCBk= Date: Sun, 8 Jul 2007 01:33:00 +0200 From: Luca Tettamanti To: Bjorn Helgaas Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Enable legacy support for serial ports when SERIAL_8250_PNP is disabled Message-ID: <20070707233300.GA3267@dreamland.darkstar.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, your patch: commit 7e92b4fc345f5b6f57585fbe5ffdb0f24d7c9b26 Author: Bjorn Helgaas Date: Tue May 8 00:36:07 2007 -0700 x86, serial: convert legacy COM ports to platform devices disables probing using legacy code in favour of ACPI/PNP to avoid double discovery. However if SERIAL_8250_PNP is not enabled the user is left without serial ports (been there, done that - my kernel config suddenly wasn't working anymore). So: Enable probing of serial ports using legacy code when PNP code (SERIAL_8250_PNP) is not enabled. Signed-off-by: Luca Tettamanti --- arch/i386/kernel/legacy_serial.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/i386/kernel/legacy_serial.c b/arch/i386/kernel/legacy_serial.c index 2151011..457d307 100644 --- a/arch/i386/kernel/legacy_serial.c +++ b/arch/i386/kernel/legacy_serial.c @@ -48,7 +48,11 @@ static struct platform_device x86_com_device = { }, }; +#ifndef CONFIG_SERIAL_8250_PNP +static int force_legacy_probe = 1; +#else static int force_legacy_probe; +#endif module_param_named(force, force_legacy_probe, bool, 0); MODULE_PARM_DESC(force, "Force legacy serial port probe"); Luca -- La vispa candela bruciava l'erbetta creando un'essenza alquanto sospetta; sembrava l'odore di una sacrestia ma presto mi accorsi che era maria.