From: David Miller <davem@davemloft.net>
To: acahalan@gmail.com
Cc: olaf@aepfle.de, hpa@zytor.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove PAGE_SIZE from headers_install
Date: Sat, 14 Jul 2007 20:43:14 -0700 (PDT) [thread overview]
Message-ID: <20070714.204314.70218766.davem@davemloft.net> (raw)
In-Reply-To: <787b0d920707141948t71b4059s7ae68610f9f81eac@mail.gmail.com>
From: "Albert Cahalan" <acahalan@gmail.com>
Date: Sat, 14 Jul 2007 22:48:57 -0400
> A real constant-value PAGE_SIZE is useful and doable.
It's bogus to use it. The kernel can get recompiled
to arbitrary page sizes on some architectures, so a constat
page size assumption cannot work.
> It's useful because a getpagesize() can't be used for numerous
> things, such as setting the size of an array.
Use dynamically allocated memory for the array then.
This isn't programming 101.
next prev parent reply other threads:[~2007-07-15 3:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 2:48 Albert Cahalan
2007-07-15 3:19 ` H. Peter Anvin
2007-07-15 3:43 ` David Miller [this message]
2007-07-15 4:49 ` Albert Cahalan
-- strict thread matches above, loose matches on Subject: below --
2007-07-14 21:40 Mikael Pettersson
2007-07-14 20:57 Olaf Hering
2007-07-14 21:04 ` Mike Frysinger
2007-07-15 6:27 ` Olaf Hering
2007-07-15 7:20 ` Mike Frysinger
2007-07-15 10:10 ` David Woodhouse
2007-08-04 10:04 ` Olaf Hering
2007-07-15 7:51 ` Olaf Hering
2007-07-14 21:12 ` H. Peter Anvin
2007-07-14 21:34 ` Olaf Hering
2007-07-14 22:59 ` Mike Frysinger
2007-07-15 8:01 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070714.204314.70218766.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acahalan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®