From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, viro@ftp.linux.org.uk
Subject: Re: [PATCH] generic_nvram: use inode lock not lock_kernel
Date: Sat, 14 Jul 2007 09:48:37 +0100 [thread overview]
Message-ID: <20070714094837.073f9bae@the-village.bc.nu> (raw)
In-Reply-To: <20070713165840.70f5f382.akpm@linux-foundation.org>
> Can we just use generic_file_llseek() in here? afacit that simply requires
> that i_size have the correct value. Does it?
Yes.
> Generic_file_llseek() uses file->f_mapping->host->i_mutex which is
> equivalent for this file, but we might as well be consistent.
Last time I used file->f_mapping->host-> for this in another driver Al
Viro asked me to use the f_path sequence instead. So I've always done
that since.
If it is correct to use the other then generic_file_llseek looks fine, if
not perhaps we need generic_device_llseek() ?
Al - there are many clones of these lseek methods - which should we be
using ?
prev parent reply other threads:[~2007-07-14 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 13:47 Alan Cox
2007-07-13 23:58 ` Andrew Morton
2007-07-14 8:48 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070714094837.073f9bae@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®