mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@tv-sign.ru>
To: Ingo Molnar <mingo@elte.hu>, Mike Galbraith <efault@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Q: a bogus task_running() check in try_to_wake_up() ?
Date: Sun, 15 Jul 2007 19:39:14 +0400	[thread overview]
Message-ID: <20070715153914.GA441@tv-sign.ru> (raw)

try_to_wake_up:
	
	if (p->se.on_rq)
		goto out_running;

	...

	if (unlikely(task_running(rq, p)))
		goto out_activate;

How it possible that rq->curr has on_rq == 0 ?

AFAICS, this can only happen if this task is rq->idle. But idle threads
should not sleep, we have a special "scheduling from the idle thread!"
check in schedule().

Thanks in advance,

Oleg.


             reply	other threads:[~2007-07-15 15:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-15 15:39 Oleg Nesterov [this message]
2007-07-17 19:05 ` Ingo Molnar
2007-07-18 16:35   ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070715153914.GA441@tv-sign.ru \
    --to=oleg@tv-sign.ru \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®